NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Console] added ProgressBar (to replace the stateful ProgressHelper class)#10355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

fabpot wants to merge1 commit intosymfony:masterfromfabpot:progress-helper-stateless

Closed

[Console] added ProgressBar (to replace the stateful ProgressHelper class)#10355

fabpot wants to merge1 commit intosymfony:masterfromfabpot:progress-helper-stateless

Conversation

Copy link

Member

fabpot commentedMar 1, 2014

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	yes
Tests pass?	yes
Fixed tickets	#9951, related to#9788
License	MIT
Doc PR	n/a

TODO:

submit a PR on the docs

This PR deprecatedProgressHelper in favor ofProgressBar. The main difference is that the newProgressBar class is stateless, which allows for more than one bar to be displayed at a time:

useSymfony\Component\Console\Helper\ProgressBar;useSymfony\Component\Console\Output\ConsoleOutput;$output =newConsoleOutput();$bar1 =newProgressBar($output,10);$bar2 =newProgressBar($output,20);$bar2->setProgressCharacter('#');$bar1->start();print"\n";$bar2->start();for ($i =1;$i <=20;$i++) {// up one line$output->write("\033[1A");usleep(100000);if ($i <=10) {$bar1->advance();    }print"\n";$bar2->advance();}

And here is how it looks like when run:

Copy link

MemberAuthor

Wouldn't it be nicer if there was a ProgressGroup or the like? There we can specify multiple progress bars and tell if it shoúld be placed horizontal or vertical. It would also handle the "moved one line up" things