Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form][Twig] Add an additional input html5 attribute if with_secondes parameters in setted#10203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
konandrum commentedFeb 4, 2014
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| License | MIT |
konandrum commentedFeb 14, 2014
Oups, i saw a big mistake, i have to change the with_minutes by with_seconds ! |
fabpot commentedMar 26, 2014
What's the status of this PR? |
konandrum commentedMar 27, 2014
Fixed, you can merge |
fabpot commentedMar 27, 2014
Can you also fix the PHP template and add some unit tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You should merge the attributes the other way round, so people can override it.
Also have you considered
The following control allows any time in the day to be selected, with any accuracy (e.g. thousandth-of-a-second accuracy or more):
<input name=favtime type=time step=any>
fabpot commentedMay 16, 2014
Closing in favor of#10777 |
…ets to display seconds if needed (tucksaun)This PR was squashed before being merged into the 2.3 branch (closes#10777).Discussion----------[Form] Automatically add step attribute to HTML5 time widgets to display seconds if needed| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#9976,#10203| License | MIT| Doc PR | noneSame issue as#9976 and#10203: when you add a `time` field to a form with options `single_text` (so HTML5) and `with_seconds`, the generated input does not contain the `step` attribute, therefore the browser does not show them, leading to an error at the submit because of an invalid format.Compared to#9976/#10203:* Unit testable* Available directly in the component* Available in other templating format than twig* Still able to customise the step attribute by handCommits-------a379298 [Form] Automatically add step attribute to HTML5 time widgets to display seconds if needed