Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DataCollector] Improves the readability of the collected arrays in the profiler.#10155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
wouterj commentedJan 28, 2014
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
may be this should be merged with theif just below ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I made it this way to improve readability, but you are right.
sukei commentedFeb 17, 2014
Nobody want that? 😟 |
sstok commentedFeb 28, 2014
Can you add some tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
is here 2 spaces or 4 spaces better?
cordoval commentedFeb 28, 2014
👍 it is a good idea |
fabpot commentedFeb 28, 2014
I don't understand how it could work with just these modifications. In my test on Symfony 2.3, 2.4, and 2.5, it just did not had the expected behavior described here. So, I've made the needed changes in#10352 |
sukei commentedFeb 28, 2014
I have a 2.4.1 and it just works as expected. |
…ted arrays in the profiler (fabpot)This PR was merged into the 2.5-dev branch.Discussion----------[DataCollector] Improves the readability of the collected arrays in the profiler| Q | A| ------------- | ---| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| License | MITThis PR is based on#10155.Original description:It simply improves the readability of the collected arrays in the profiler:__before__:```Array(date => Array(year => , month => , day => ), time => Array(hour => ))```__after__:```[ date => [ year => , month => , day => ], time => [ hour => ]]```Commits-------dce66c9 removed double-stringification of values in the profiler1cda2d4 [HttpKernel] tweaked value exporter3f297ea Improves the readability of the collected arrays in the profiler.
It simply improves the readability of the collected arrays in the profiler:
before:
after: