Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[BrowserKit] add non-standard port to HTTP_HOST server param#10078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the parenthesis should be removed around the assignment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If the port is empty, you're going to add a: at the end, which is not what you expect. So, you must check against80 and the empty string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
which made two tests from the BrowserKit componentfail.
cordoval commentedJan 20, 2014
does this need also a regression test? |
kbond commentedJan 20, 2014
I have simplified and added some tests. |
kbond commentedJan 23, 2014
I suppose this should be merged to the 2.3 branch. |
fabpot commentedJan 24, 2014
Thank you@kbond. |
…am (kbond)This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#10078).Discussion----------[BrowserKit] add non-standard port to HTTP_HOST server param| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |https://github.com/Behat/MinkGoutteDriver/issues/25| License | MIT| Doc PR | n/aThis fix will allow using BrowserKit with php's webserver.Commits-------5f25639 [BrowserKit] add non-standard port to HTTP_HOST
This fix will allow using BrowserKit with php's webserver.