Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Form] Add option to ignore invalid choices#10008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
trsteel88 wants to merge3 commits intosymfony:masterfromtrsteel88:master
Closed

[Form] Add option to ignore invalid choices#10008

trsteel88 wants to merge3 commits intosymfony:masterfromtrsteel88:master

Conversation

trsteel88
Copy link
Contributor

QA
Bug fix?No
New feature?Yes
BC breaks?No
Deprecations?No
Tests pass?Yes
Fixed tickets#9738
LicenseMIT

@jakzal
Copy link
Contributor

Please include aPR checklist in the description.

@jakzal
Copy link
Contributor

I'm not convinced this is the best approach to solve#9738. Since any missing fields would be ignored and no error would be raised, user might expect that all his choices were saved.

@trsteel88
Copy link
ContributorAuthor

@jakzal Yes, but it would only be used in the case where there might be outdated data. Eg, I am using it on a search form where the options can change quite often. Therefore, I don't want an error to be thrown because the search option chosen no longer exists. I still want the form to search with the options which are now available.

PR checklist has been added.

@stof
Copy link
Member

I see a real issue here: the option is not applied consistently

@trsteel88
Copy link
ContributorAuthor

@stof how do you mean? Do you mean for non expanded etc? This would only apply where the field is expanded and allows multiple options.

@stof
Copy link
Member

why wouldn't it apply for non-expanded fields allowing multiple selection ? there is no difference between expanded and collapsed rendering of the choice fields as far as the submission processing is concerned (the submitted data looks exactly the same in both cases)

@trsteel88
Copy link
ContributorAuthor

Ah, yes it should. Sorry, I will fix up tomorrow morning

@trsteel88
Copy link
ContributorAuthor

@stof that has been updated. Let me know if there is anything else

@webmozartwebmozart changed the titleadd option to ignore invalid choices[Form] Add option to ignore invalid choicesApr 8, 2014
@webmozart
Copy link
Contributor

Hi@trsteel88, thank you for that PR! Unfortunately,#12148 changes quite a bit of the code that is touched by this PR. Hence this needs to be redone when#12148 is merged.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@trsteel88@jakzal@stof@webmozart

[8]ページ先頭

©2009-2025 Movatter.jp