NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Validator] Fixed constraint violation to string not handling array#10007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

eduardosoliv wants to merge1 commit intosymfony:masterfromeduardosoliv:validator-cviolation-tostring-handle-array

Closed

[Validator] Fixed constraint violation to string not handling array#10007

eduardosoliv wants to merge1 commit intosymfony:masterfromeduardosoliv:validator-cviolation-tostring-handle-array

Conversation

Copy link

Contributor

eduardosoliv commentedJan 12, 2014

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR

This bug was introduced onPR-790 [2.3] [Validator] added comparison constraints and validators

Due to the change on root (to become the value):

-        $context = new ExecutionContext($this->createVisitor(null), $this->translator, $this->translationDomain);+        $context = new ExecutionContext($this->createVisitor($value), $this->translator, $this->translationDomain);

https://github.com/symfony/symfony/pull/790/files#diff-f4a93c3d8fcb85a24ea41c2a993e6d83R163

My change on:

-        $class = (string) (is_object($this->root) ? get_class($this->root) : $this->root);+        $class = is_object($this->root)+            ? get_class($this->root)+            : (is_array($this->root) ? 'Array' : (string) $this->root);+

Is inspired onTypeValidator