Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Routing condition bugfix#10002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Routing condition bugfix#10002
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
you must add a space afterif.
fabpot commentedJan 13, 2014
Can you add some unit tests as well? |
m3co-code commentedJan 14, 2014
Yes, I will add some tests and correct the formatting! |
…en importing sub routes in the YamlFileLoader.
…en importing sub routes in the XmlFileLoader.
m3co-code commentedJan 14, 2014
Done, does the testing setup makes sense? Don't wanted to duplicate everything. |
Koc commentedJan 24, 2014
@fabpot can you please merge this PR? |
fabpot commentedJan 24, 2014
Thank you @marco-jantke. |
This PR was submitted for the 2.4-dev branch but it was merged into the 2.4 branch instead (closes#10002).Discussion----------Routing condition bugfix[Routing] Fixed inheriting of condition to sub routes for xml and yaml configuration.Commits-------bb7e15e Routing condition bugfix
[Routing] Fixed inheriting of condition to sub routes for xml and yaml configuration.