Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Comparing changes
Open a pull request
base repository:symfony/symfony
Uh oh!
There was an error while loading.Please reload this page.
base:v4.1.0-BETA3
head repository:symfony/symfony
Uh oh!
There was an error while loading.Please reload this page.
compare:v4.1.0
- 10commits
- 25files changed
- 4contributors
Commits on May 29, 2018
minor#27393[Form] mention "help" field option in UPGRADE file (mhujer)
This PR was merged into the 4.1 branch.Discussion----------[Form] mention "help" field option in UPGRADE file| Q | A| ------------- | ---| Branch? | 4.1 <!-- see below -->| Bug fix? | no| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License | MITWhen you have your own Form Extension to handle help option (e.g. similar to the one mentioned in the [blog post](https://symfony.com/blog/new-in-symfony-4-1-form-field-help)), it starts to render twice in the form after upgrading to 4.1 (where#26332 was added)<!--Write a short README entry for your feature/bugfix here (replace this comment block.)This will help people understand your PR and can be used as a start of the Doc PR.Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch.-->Commits-------744362a update UPGRADE-4.1 for feature#26332 Form field help option
nicolas-grekas committedMay 29, 2018
Commits on May 30, 2018
Revert "feature#26702Mark ExceptionInterfaces throwable (ostrolucky)"
nicolas-grekas committedMay 30, 2018 bug#27415Insert correct parameter_bag service in AbstractController…
… (curry684)This PR was submitted for the master branch but it was squashed and merged into the 4.1 branch instead (closes#27415).Discussion----------Insert correct parameter_bag service in AbstractControllerReverts this feature being broken in3051289#diff-ef10778bc68793f8c8f4b71a7ba67790R86 - `getParameter` could never work now as it was querying the container itself instead of the parameter bag.| Q | A| ------------- | ---| Branch? | 4.1| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers -->| License | MITAlso see comments at#25439 (comment)Commits-------37270d7 Insert correct parameter_bag service in AbstractController
nicolas-grekas committedMay 30, 2018 bug#27420Revert "feature#26702Mark ExceptionInterfaces throwable …
…(ostrolucky)" (nicolas-grekas)This PR was merged into the 4.1 branch.Discussion----------Revert "feature#26702 Mark ExceptionInterfaces throwable (ostrolucky)"This reverts commit9fda6d3, reversingchanges made toca53d3e.| Q | A| ------------- | ---| Branch? | 4.1| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#27419| License | MIT| Doc PR | -#26702 introduced a BC break.Commits-------2ddb89b Revert "feature#26702 Mark ExceptionInterfaces throwable (ostrolucky)"
nicolas-grekas committedMay 30, 2018 - fabpot committed
May 30, 2018 - fabpot committed
May 30, 2018
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff v4.1.0-BETA3...v4.1.0
Uh oh!
There was an error while loading.Please reload this page.