Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Comparing changes
Open a pull request
base repository:symfony/symfony
Uh oh!
There was an error while loading.Please reload this page.
base:v3.3.1
head repository:symfony/symfony
Uh oh!
There was an error while loading.Please reload this page.
compare:v3.3.2
- 15commits
- 9files changed
- 7contributors
Commits on May 29, 2017
mix attr options between type-guess options and user options
yceruto committedMay 29, 2017
Commits on Jun 3, 2017
bug#22976[DependencyInjection] Use more clear message when unused e…
…nvironment variables detected (voronkovich)This PR was squashed before being merged into the 3.2 branch (closes#22976).Discussion----------[DependencyInjection] Use more clear message when unused environment variables detected| Q | A| ------------- | ---| Branch? |3.2| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#22955| License | MITOld error message:```Incompatible use of dynamic environment variables "DATABASE_URL", "MAILER_URL" found in parameters.```New error message:```Environment variables "DATABASE_URL", "MAILER_URL" are never used. Please, check your container's configuration.```Commits-------6dbdb1b [DependencyInjection] Use more clear message when unused environment variables detected
fabpot committedJun 3, 2017 bug#22936[Form] Mix attr option between guessed options and user op…
…tions (yceruto)This PR was merged into the 2.7 branch.Discussion----------[Form] Mix attr option between guessed options and user options| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#19871| License | MITCommits-------84f5de9 mix attr options between type-guess options and user options
fabpot committedJun 3, 2017
Commits on Jun 5, 2017
[Cache] MemcachedAdapter not working with TagAwareAdapter
It seems that when MemcachedAdapter is used with TagAwareAdapter, it fails to fetch items, even though I thoroughly tested fetching items with the exact same keys under the same namespace.Turns out the issue lies in `const TAGS_PREFIX = "\0tags\0";` for unknown to me reasons. Hardcoding that to '__tags__' in my project did the trick and I've been using it for a couple of days now and it seems fine.The reason I had to completely copy/paste this file in my local project is self:: instead of static:: usage. I am not sure whether that is a mistake or is done on purpose, but in order to have this work for me I need to be able to override that constant. Going with static:: seems like a good solution to me, then I can set whatever prefix I need for the tags.
bug#23063[Cache] Fix extensibility of TagAwareAdapter::TAGS_PREFIX …
…(wucdbm)This PR was submitted for the 3.3 branch but it was merged into the 3.2 branch instead (closes#23063).Discussion----------[Cache] Fix extensibility of TagAwareAdapter::TAGS_PREFIX| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |It seems that when MemcachedAdapter is used with TagAwareAdapter, it fails to fetch items, even though I thoroughly tested fetching items with the exact same keys under the same namespace.Edit: Just to clarify, `CacheItem::isHit()` always returned `false`. This is what I meant with the above.Turns out the issue lies in `const TAGS_PREFIX = "\0tags\0";` for unknown to me reasons. Hardcoding that to `'__tags__'` in my project did the trick and I've been using it for a couple of days now and it seems fine.The reason I had to completely copy/paste this file in my local project is `self::` instead of `static::` usage. I am not sure whether that is a mistake or is done on purpose, but in order to have this work for me I need to be able to override that constant. Going with static:: seems like a good solution to me, then I can set whatever prefix I need for the tags.PS: Not exactly sure what to do with tests. Any help would be appreciated.Commits-------405f64b [Cache] MemcachedAdapter not working with TagAwareAdapter
nicolas-grekas committedJun 5, 2017 bumped Symfony version to 3.3.2
fabpot committedJun 5, 2017
Commits on Jun 6, 2017
bug#23073[TwigBridge] Fix namespaced classes (ogizanagi)
This PR was merged into the 2.7 branch.Discussion----------[TwigBridge] Fix namespaced classes| Q | A| ------------- | ---| Branch? | 2.7 <!-- see comment below -->| Bug fix? | yes| New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files -->| BC breaks? | no| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->| Tests pass? | yes| Fixed tickets |#23072 <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | N/ACommits-------a1cdc2d [TwigBridge] Fix namespaced classes
fabpot committedJun 6, 2017 * 2.7: [TwigBridge] Fix namespaced classes mix attr options between type-guess options and user options
fabpot committedJun 6, 2017 * 2.8: [TwigBridge] Fix namespaced classes mix attr options between type-guess options and user options
fabpot committedJun 6, 2017 * 3.2: [TwigBridge] Fix namespaced classes [Cache] MemcachedAdapter not working with TagAwareAdapter [DependencyInjection] Use more clear message when unused environment variables detected mix attr options between type-guess options and user options
nicolas-grekas committedJun 6, 2017 - fabpot committed
Jun 6, 2017 - fabpot committed
Jun 6, 2017
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff v3.3.1...v3.3.2
Uh oh!
There was an error while loading.Please reload this page.