NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Commitfad545a

committed

minor#19163 [Console] removed unneeded private methods (fabpot)

This PR was merged into the 2.7 branch.Discussion----------[Console] removed unneeded private methods| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |https://github.com/symfony/symfony/pull/19134/files/3871e1a95056ce8278e6b86d3e8005836ecab954#r68286709| License | MIT| Doc PR | n/aCommits-------35f32eb [Console] removed unneeded private methods

2 parents448a390 +35f32eb commitfad545aCopy full SHA for fad545a

File tree

1 file changed

-12

lines changed

src/Symfony/Component/Console/Helper
- ProgressBar.php

1 file changed

-12

lines changed

`‎src/Symfony/Component/Console/Helper/ProgressBar.php‎`

Lines changed: 2 additions & 12 deletions

Original file line number	Diff line number	Diff line change
`@@ -523,7 +523,7 @@ private function setMaxSteps($max)`
`523`	`523`	`privatefunctionoverwrite($message)`
`524`	`524`	`{`
`525`	`525`	`if ($this->overwrite) {`
`526`		`-if (!$this->isFirstRun()) {`
	`526`	`+if (!$this->firstRun) {`
`527`	`527`	`// Move the cursor to the beginning of the line`
`528`	`528`	`$this->output->write("\x0D");`
`529`	`529`
`@@ -539,7 +539,7 @@ private function overwrite($message)`
`539`	`539`	`$this->output->writeln('');`
`540`	`540`	`}`
`541`	`541`
`542`		`-$this->setFirstRun(false);`
	`542`	`+$this->firstRun =false;`
`543`	`543`
`544`	`544`	`$this->output->write($message);`
`545`	`545`	`}`
`@@ -632,14 +632,4 @@ private static function initFormats()`
`632`	`632`	`'debug_nomax' =>' %current% [%bar%] %elapsed:6s% %memory:6s%',`
`633`	`633`	`);`
`634`	`634`	`}`
`635`		`-`
`636`		`-privatefunctionisFirstRun()`
`637`		`- {`
`638`		`-return$this->firstRun;`
`639`		`- }`
`640`		`-`
`641`		`-privatefunctionsetFirstRun($firstRun)`
`642`		`- {`
`643`		`-$this->firstRun = (bool)$firstRun;`
`644`		`- }`
`645`	`635`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitfad545a

File tree

1 file changed

1 file changed

`‎src/Symfony/Component/Console/Helper/ProgressBar.php‎`

0 commit comments