NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Commitf91c40a

committed

bug#44473 [Validator] Restore default locale in ConstraintValidatorTestCase (rodnaph)

This PR was merged into the 4.4 branch.Discussion----------[Validator] Restore default locale in ConstraintValidatorTestCase| Q | A| ------------- | ---| Branch? | 6.1| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | N/A| License | MIT| Doc PR | N/APreviously this code was not resetting the locale after changing it to `en` - which affected other tests which relied on this value being the configured value (however it was configured).This mirrors the pattern used for the timezone, storing it to be reset on tearDown.I've based this on 6.1. If it's valid, I'm unsure if it's classed a bug, or needs UPGRADE notes?Commits-------77267c0 restore the overriden locale on tearDown - avoid interfering with any configured value

2 parentsaaa18df +77267c0 commitf91c40aCopy full SHA for f91c40a

File tree

1 file changed

-0

lines changed

src/Symfony/Component/Validator/Test
- ConstraintValidatorTestCase.php

1 file changed

-0

lines changed

`‎src/Symfony/Component/Validator/Test/ConstraintValidatorTestCase.php‎`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,7 @@ abstract class ConstraintValidatorTestCase extends TestCase`
`58`	`58`	`protected$propertyPath;`
`59`	`59`	`protected$constraint;`
`60`	`60`	`protected$defaultTimezone;`
	`61`	`+private$defaultLocale;`
`61`	`62`
`62`	`63`	`privatefunctiondoSetUp()`
`63`	`64`	`{`
`@@ -76,6 +77,7 @@ private function doSetUp()`
`76`	`77`	`$this->validator =$this->createValidator();`
`77`	`78`	`$this->validator->initialize($this->context);`
`78`	`79`
	`80`	`+$this->defaultLocale = \Locale::getDefault();`
`79`	`81`	`\Locale::setDefault('en');`
`80`	`82`
`81`	`83`	`$this->setDefaultTimezone('UTC');`
`@@ -84,6 +86,8 @@ private function doSetUp()`
`84`	`86`	`privatefunctiondoTearDown()`
`85`	`87`	`{`
`86`	`88`	`$this->restoreDefaultTimezone();`
	`89`	`+`
	`90`	`+ \Locale::setDefault($this->defaultLocale);`
`87`	`91`	`}`
`88`	`92`
`89`	`93`	`protectedfunctionsetDefaultTimezone($defaultTimezone)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitf91c40a

File tree

1 file changed

1 file changed

`‎src/Symfony/Component/Validator/Test/ConstraintValidatorTestCase.php‎`

0 commit comments