Commitf84c83b

committed

[HttpClient] Check satus code before decoding in TraceableResponse::toArray()

1 parenta29af81 commitf84c83bCopy full SHA for f84c83b

File tree

+15

-2

lines changed

src/Symfony/Component/HttpClient
- Response
  - TraceableResponse.php
- Tests
  - TraceableHttpClientTest.php

+15

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -63,12 +63,12 @@ public function getContent(bool $throw = true): string`
`63`	`63`
`64`	`64`	`publicfunctiontoArray(bool$throw =true):array`
`65`	`65`	`{`
`66`		`-$this->content =$this->response->toArray(false);`
`67`		`-`
`68`	`66`	`if ($throw) {`
`69`	`67`	`$this->checkStatusCode($this->response->getStatusCode());`
`70`	`68`	`}`
`71`	`69`
	`70`	`+$this->content =$this->response->toArray(false);`
	`71`	`+`
`72`	`72`	`return$this->content;`
`73`	`73`	`}`
`74`	`74`

Lines changed: 13 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@`
`16`	`16`	`useSymfony\Component\HttpClient\NativeHttpClient;`
`17`	`17`	`useSymfony\Component\HttpClient\Response\MockResponse;`
`18`	`18`	`useSymfony\Component\HttpClient\TraceableHttpClient;`
	`19`	`+useSymfony\Contracts\HttpClient\Exception\ClientExceptionInterface;`
`19`	`20`	`useSymfony\Contracts\HttpClient\HttpClientInterface;`
`20`	`21`	`useSymfony\Contracts\HttpClient\Test\TestHttpServer;`
`21`	`22`
`@@ -100,4 +101,16 @@ public function testStream()`
`100`	`101`	`$this->assertGreaterThan(1,\count($chunks));`
`101`	`102`	`$this->assertSame('Symfony is awesome!',implode('',$chunks));`
`102`	`103`	`}`
	`104`	`+`
	`105`	`+publicfunctiontestToArrayChecksStatusCodeBeforeDecoding()`
	`106`	`+ {`
	`107`	`+$this->expectException(ClientExceptionInterface::class);`
	`108`	`+`
	`109`	`+$sut =newTraceableHttpClient(newMockHttpClient($responseFactory =function ():MockResponse {`
	`110`	`+returnnewMockResponse('Errored.', ['http_code' =>400]);`
	`111`	`+ }));`
	`112`	`+`
	`113`	`+$response =$sut->request('GET','https://example.com/foo/bar');`
	`114`	`+$response->toArray();`
	`115`	`+ }`
`103`	`116`	`}`

Comments

(0)