Commitf7158bd

committed

[Validator] Fix type error for non-array items when Unique::fields is set

1 parent9145a88 commitf7158bdCopy full SHA for f7158bd

File tree

+25

-1

lines changed

src/Symfony/Component/Validator
- Constraints
  - UniqueValidator.php
- Tests/Constraints
  - UniqueValidatorTest.php

+25

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ public function validate(mixed $value, Constraint $constraint)`
`43`	`43`	`$collectionElements = [];`
`44`	`44`	`$normalizer =$this->getNormalizer($constraint);`
`45`	`45`	`foreach ($valueas$element) {`
`46`		`-if ($fields && !$element=$this->reduceElementKeys($fields,$element)) {`
	`46`	`+if ($fields && !(\is_array($element) &&$element=$this->reduceElementKeys($fields,$element))) {`
`47`	`47`	`continue;`
`48`	`48`	`}`
`49`	`49`

Lines changed: 24 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -242,6 +242,30 @@ public static function getInvalidFieldNames(): array`
`242`	`242`	`];`
`243`	`243`	`}`
`244`	`244`
	`245`	`+/**`
	`246`	`+ * @dataProvider getValidCollectionValues`
	`247`	`+ */`
	`248`	`+publicfunctiontestValidCollectionValues(array$value,array$fields)`
	`249`	`+ {`
	`250`	`+$this->validator->validate($value,newUnique(fields:$fields));`
	`251`	`+`
	`252`	`+$this->assertNoViolation();`
	`253`	`+ }`
	`254`	`+`
	`255`	`+publicstaticfunctiongetValidCollectionValues():array`
	`256`	`+ {`
	`257`	`+return [`
	`258`	`+'unique empty item' => [`
	`259`	`+ [['field' =>1], ['field' =>2], []],`
	`260`	`+ ['field'],`
	`261`	`+ ],`
	`262`	`+'unique non-array item' => [`
	`263`	`+ [['field' =>1], ['field' =>2],'',1,null],`
	`264`	`+ ['field'],`
	`265`	`+ ],`
	`266`	`+ ];`
	`267`	`+ }`
	`268`	`+`
`245`	`269`	`/**`
`246`	`270`	`* @dataProvider getInvalidCollectionValues`
`247`	`271`	`*/`

Comments

(0)