Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commitf2ef55c

Browse files
committed
feature#42337 [Validator] Remove internal fromConstraintViolationAssertion (jordisala1991)
This PR was merged into the 5.4 branch.Discussion----------[Validator] Remove internal from `ConstraintViolationAssertion`| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets |Fix#42310| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/releases): - Always add tests and ensure they pass. - Never break backward compatibility (seehttps://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch 5.x. - Changelog entry should followhttps://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry-->As requested on the issue, I made this class final instead of internal and the construct method is internal.Commits-------97949ea Remove internal from ConstraintViolationAssertion
2 parentsa424be8 +97949ea commitf2ef55c

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

‎src/Symfony/Component/Validator/Test/ConstraintValidatorTestCase.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -293,10 +293,7 @@ protected function buildViolation($message)
293293
abstractprotectedfunctioncreateValidator();
294294
}
295295

296-
/**
297-
* @internal
298-
*/
299-
class ConstraintViolationAssertion
296+
finalclass ConstraintViolationAssertion
300297
{
301298
/**
302299
* @var ExecutionContextInterface
@@ -317,6 +314,9 @@ class ConstraintViolationAssertion
317314
private$constraint;
318315
private$cause;
319316

317+
/**
318+
* @internal
319+
*/
320320
publicfunction__construct(ExecutionContextInterface$context,string$message,Constraint$constraint =null,array$assertions = [])
321321
{
322322
$this->context =$context;

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp