Commitf21ee5f

committed

Remove HelperSet::setCommand() and getCommand()

Signed-off-by: Alexander M. Turek <me@derrabus.de>

1 parent7a3ab9e commitf21ee5fCopy full SHA for f21ee5f

File tree

-52

lines changed

-52

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@ CHANGELOG`
`8`	`8`	* Remove`Helper::strlen()`, use`Helper::width()` instead
`9`	`9`	* Remove`Helper::strlenWithoutDecoration()`, use`Helper::removeDecoration()` instead
`10`	`10`	*`AddConsoleCommandPass` can not be configured anymore
	`11`	+* Remove`HelperSet::setCommand()` and`getCommand()` without replacement
`11`	`12`
`12`	`13`	`5.4`
`13`	`14`	`---`

Lines changed: 0 additions & 23 deletions

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,6 @@ class HelperSet implements \IteratorAggregate`
`25`	`25`	`* @var Helper[]`
`26`	`26`	`*/`
`27`	`27`	`private$helpers = [];`
`28`		`-private$command;`
`29`	`28`
`30`	`29`	`/**`
`31`	`30`	`* @param Helper[] $helpers An array of helper`
`@@ -69,28 +68,6 @@ public function get(string $name): HelperInterface`
`69`	`68`	`return$this->helpers[$name];`
`70`	`69`	`}`
`71`	`70`
`72`		`-/**`
`73`		`- * @deprecated since Symfony 5.4`
`74`		`- */`
`75`		`-publicfunctionsetCommand(Command$command =null)`
`76`		`- {`
`77`		`-trigger_deprecation('symfony/console','5.4','Method "%s()" is deprecated.',__METHOD__);`
`78`		`-`
`79`		`-$this->command =$command;`
`80`		`- }`
`81`		`-`
`82`		`-/**`
`83`		`- * Gets the command associated with this helper set.`
`84`		`- *`
`85`		`- * @deprecated since Symfony 5.4`
`86`		`- */`
`87`		`-publicfunctiongetCommand():Command`
`88`		`- {`
`89`		`-trigger_deprecation('symfony/console','5.4','Method "%s()" is deprecated.',__METHOD__);`
`90`		`-`
`91`		`-return$this->command;`
`92`		`- }`
`93`		`-`
`94`	`71`	`/**`
`95`	`72`	`* @return \Traversable<string, Helper>`
`96`	`73`	`*/`

Lines changed: 0 additions & 29 deletions

Original file line number	Diff line number	Diff line change
`@@ -74,35 +74,6 @@ public function testGet()`
`74`	`74`	`}`
`75`	`75`	`}`
`76`	`76`
`77`		`-/**`
`78`		`- * @group legacy`
`79`		`- */`
`80`		`-publicfunctiontestSetCommand()`
`81`		`- {`
`82`		`-$cmd_01 =newCommand('foo');`
`83`		`-$cmd_02 =newCommand('bar');`
`84`		`-`
`85`		`-$helperset =newHelperSet();`
`86`		`-$helperset->setCommand($cmd_01);`
`87`		`-$this->assertEquals($cmd_01,$helperset->getCommand(),'->setCommand() stores given command');`
`88`		`-`
`89`		`-$helperset =newHelperSet();`
`90`		`-$helperset->setCommand($cmd_01);`
`91`		`-$helperset->setCommand($cmd_02);`
`92`		`-$this->assertEquals($cmd_02,$helperset->getCommand(),'->setCommand() overwrites stored command with consecutive calls');`
`93`		`- }`
`94`		`-`
`95`		`-/**`
`96`		`- * @group legacy`
`97`		`- */`
`98`		`-publicfunctiontestGetCommand()`
`99`		`- {`
`100`		`-$cmd =newCommand('foo');`
`101`		`-$helperset =newHelperSet();`
`102`		`-$helperset->setCommand($cmd);`
`103`		`-$this->assertEquals($cmd,$helperset->getCommand(),'->getCommand() retrieves stored command');`
`104`		`- }`
`105`		`-`
`106`	`77`	`publicfunctiontestIteration()`
`107`	`78`	`{`
`108`	`79`	`$helperset =newHelperSet();`

Comments

(0)