Commitf06b842

committed

a readonly property must not be reported as being writable

1 parentc959125 commitf06b842Copy full SHA for f06b842

File tree

+22

-2

lines changed

+22

-2

lines changed

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,7 @@ public function isReadable($class, $property, array $context = []): ?bool`
`180`	`180`	`*/`
`181`	`181`	`publicfunctionisWritable($class,$property,array$context = []): ?bool`
`182`	`182`	`{`
`183`		`-if ($this->isAllowedProperty($class,$property)) {`
	`183`	`+if ($this->isAllowedProperty($class,$property,true)) {`
`184`	`184`	`returntrue;`
`185`	`185`	`}`
`186`	`186`
`@@ -389,11 +389,15 @@ private function isNullableProperty(string $class, string $property): bool`
`389`	`389`	`returnfalse;`
`390`	`390`	`}`
`391`	`391`
`392`		`-privatefunctionisAllowedProperty(string$class,string$property):bool`
	`392`	`+privatefunctionisAllowedProperty(string$class,string$property,bool$writeAccessRequired =false):bool`
`393`	`393`	`{`
`394`	`394`	`try {`
`395`	`395`	`$reflectionProperty =new \ReflectionProperty($class,$property);`
`396`	`396`
	`397`	`+if (\PHP_VERSION_ID >=80100 &&$writeAccessRequired &&$reflectionProperty->isReadOnly()) {`
	`398`	`+returnfalse;`
	`399`	`+ }`
	`400`	`+`
`397`	`401`	`if ($this->accessFlags &self::ALLOW_PUBLIC &&$reflectionProperty->isPublic()) {`
`398`	`402`	`returntrue;`
`399`	`403`	`}`

Lines changed: 12 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@`
`22`	`22`	`useSymfony\Component\PropertyInfo\Tests\Fixtures\Php74Dummy;`
`23`	`23`	`useSymfony\Component\PropertyInfo\Tests\Fixtures\Php7Dummy;`
`24`	`24`	`useSymfony\Component\PropertyInfo\Tests\Fixtures\Php7ParentDummy;`
	`25`	`+useSymfony\Component\PropertyInfo\Tests\Fixtures\Php81Dummy;`
`25`	`26`	`useSymfony\Component\PropertyInfo\Type;`
`26`	`27`
`27`	`28`	`/**`
`@@ -234,6 +235,7 @@ public function php71TypesProvider()`
`234`	`235`
`235`	`236`	`/**`
`236`	`237`	`* @dataProvider php80TypesProvider`
	`238`	`+ *`
`237`	`239`	`* @requires PHP 8`
`238`	`240`	`*/`
`239`	`241`	`publicfunctiontestExtractPhp80Type($property,array$type =null)`
`@@ -257,6 +259,7 @@ public function php80TypesProvider()`
`257`	`259`
`258`	`260`	`/**`
`259`	`261`	`* @dataProvider php81TypesProvider`
	`262`	`+ *`
`260`	`263`	`* @requires PHP 8.1`
`261`	`264`	`*/`
`262`	`265`	`publicfunctiontestExtractPhp81Type($property,array$type =null)`
`@@ -272,8 +275,17 @@ public function php81TypesProvider()`
`272`	`275`	`];`
`273`	`276`	`}`
`274`	`277`
	`278`	`+/**`
	`279`	`+ * @requires PHP 8.1`
	`280`	`+ */`
	`281`	`+publicfunctiontestReadonlyPropertiesAreNotWriteable()`
	`282`	`+ {`
	`283`	`+$this->assertFalse($this->extractor->isWritable(Php81Dummy::class,'foo'));`
	`284`	`+ }`
	`285`	`+`
`275`	`286`	`/**`
`276`	`287`	`* @dataProvider php82TypesProvider`
	`288`	`+ *`
`277`	`289`	`* @requires PHP 8.2`
`278`	`290`	`*/`
`279`	`291`	`publicfunctiontestExtractPhp82Type($property,array$type =null)`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,10 @@`
`13`	`13`
`14`	`14`	`class Php81Dummy`
`15`	`15`	`{`
	`16`	`+publicfunction__construct(publicreadonlystring$foo)`
	`17`	`+ {`
	`18`	`+ }`
	`19`	`+`
`16`	`20`	`publicfunctiongetNothing(): never`
`17`	`21`	`{`
`18`	`22`	`thrownew \Exception('Oops');`

Comments

(0)