NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Commitef3df52

committed

bug#47626 [Notifier] [Expo] Throw exception on error-response from expo api (sdrewergutland)

This PR was squashed before being merged into the 5.4 branch.Discussion----------[Notifier] [Expo] Throw exception on error-response from expo api| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -Throw an actual `TransportException`in the case that an error is returned in the response from expo api.Commits-------90638ac [Notifier] [Expo] Throw exception on error-response from expo api

2 parents7dc9d04 +90638ac commitef3df52Copy full SHA for ef3df52

File tree

1 file changed

-2

lines changed

src/Symfony/Component/Notifier/Bridge/Expo
- ExpoTransport.php

1 file changed

-2

lines changed

`‎src/Symfony/Component/Notifier/Bridge/Expo/ExpoTransport.php‎`

Lines changed: 9 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,9 @@ public function supports(MessageInterface $message): bool`
`50`	`50`	`return$messageinstanceof PushMessage;`
`51`	`51`	`}`
`52`	`52`
	`53`	`+/**`
	`54`	`+ * @see https://docs.expo.dev/push-notifications/sending-notifications/#http2-api`
	`55`	`+ */`
`53`	`56`	`protectedfunctiondoSend(MessageInterface$message):SentMessage`
`54`	`57`	`{`
`55`	`58`	`if (!$messageinstanceof PushMessage) {`
`@@ -91,10 +94,14 @@ protected function doSend(MessageInterface $message): SentMessage`
`91`	`94`	`thrownewTransportException('Unable to post the Expo message:'.$errorMessage,$response);`
`92`	`95`	`}`
`93`	`96`
`94`		`-$success =$response->toArray(false);`
	`97`	`+$result =$response->toArray(false);`
	`98`	`+`
	`99`	`+if ('error' ===$result['data']['status']) {`
	`100`	`+thrownewTransportException(sprintf('Unable to post the Expo message: "%s" (%s)',$result['data']['message'],$result['data']['details']['error']),$response);`
	`101`	`+ }`
`95`	`102`
`96`	`103`	`$sentMessage =newSentMessage($message, (string)$this);`
`97`		`-$sentMessage->setMessageId($success['data']['id']);`
	`104`	`+$sentMessage->setMessageId($result['data']['id']);`
`98`	`105`
`99`	`106`	`return$sentMessage;`
`100`	`107`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitef3df52

File tree

1 file changed

1 file changed

`‎src/Symfony/Component/Notifier/Bridge/Expo/ExpoTransport.php‎`

0 commit comments