Commitef10cac

committed

[HttpFoundation] Deprecate not passing aClosure together withFILTER_CALLBACK toParameterBag::filter()

1 parentabcc0b8 commitef10cacCopy full SHA for ef10cac

File tree

+17

-0

lines changed

+17

-0

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,11 @@ Form`
`39`	`39`	`$builder->setDataMapper(new DataMapper(new PropertyPathAccessor()));`
`40`	`40`	```
`41`	`41`
	`42`	`+HttpFoundation`
	`43`	`+--------------`
	`44`	`+`
	`45`	+* Deprecated not passing a`Closure` together with`FILTER_CALLBACK` to`ParameterBag::filter()`; wrap your filter in a closure instead.
	`46`	`+`
`42`	`47`	`Lock`
`43`	`48`	`----`
`44`	`49`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -66,6 +66,7 @@ HttpFoundation`
`66`	`66`	* Removed`Response::create()`,`JsonResponse::create()`,
`67`	`67`	`RedirectResponse::create()`, and`StreamedResponse::create()` methods (use
`68`	`68`	`__construct()` instead)
	`69`	+* Not passing a`Closure` together with`FILTER_CALLBACK` to`ParameterBag::filter()` throws an`InvalidArgumentException`; wrap your filter in a closure instead.
`69`	`70`
`70`	`71`	`HttpKernel`
`71`	`72`	`----------`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@ CHANGELOG`
`10`	`10`	* added ability to use comma separated ip addresses for`RequestMatcher::matchIps()`
`11`	`11`	* added`Request::toArray()` to parse a JSON request body to an array
`12`	`12`	* added`RateLimiter\RequestRateLimiterInterface` and`RateLimiter\AbstractRequestRateLimiter`
	`13`	+* deprecated not passing a`Closure` together with`FILTER_CALLBACK` to`ParameterBag::filter()`; wrap your filter in a closure instead.
`13`	`14`
`14`	`15`	`5.1.0`
`15`	`16`	`-----`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -103,6 +103,11 @@ public function filter(string $key, $default = null, int $filter = \FILTER_DEFAU`
`103`	`103`	`}`
`104`	`104`	`}`
`105`	`105`
	`106`	`+if ((\FILTER_CALLBACK &$filter) && !(($options['options'] ??null)instanceof \Closure)) {`
	`107`	`+trigger_deprecation('symfony/http-foundation','5.2','Not passing a Closure together with FILTER_CALLBACK to "%s()" is deprecated. Wrap your filter in a closure instead.',__METHOD__);`
	`108`	`+// throw new \InvalidArgumentException(sprintf('A Closure must be passed to "%s()" when FILTER_CALLBACK is used, "%s" given.', __METHOD__, get_debug_type($options['options'] ?? null)));`
	`109`	`+ }`
	`110`	`+`
`106`	`111`	`returnfilter_var($value,$filter,$options);`
`107`	`112`	`}`
`108`	`113`	`}`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -194,6 +194,11 @@ public function filter(string $key, $default = null, int $filter = \FILTER_DEFAU`
`194`	`194`	`$options['flags'] = \FILTER_REQUIRE_ARRAY;`
`195`	`195`	`}`
`196`	`196`
	`197`	`+if ((\FILTER_CALLBACK &$filter) && !(($options['options'] ??null)instanceof \Closure)) {`
	`198`	`+trigger_deprecation('symfony/http-foundation','5.2','Not passing a Closure together with FILTER_CALLBACK to "%s()" is deprecated. Wrap your filter in a closure instead.',__METHOD__);`
	`199`	`+// throw new \InvalidArgumentException(sprintf('A Closure must be passed to "%s()" when FILTER_CALLBACK is used, "%s" given.', __METHOD__, get_debug_type($options['options'] ?? null)));`
	`200`	`+ }`
	`201`	`+`
`197`	`202`	`returnfilter_var($value,$filter,$options);`
`198`	`203`	`}`
`199`	`204`

Comments

(0)