Commiteacb74c

authored and

committed

[Config] Allow custom meta location inConfigCache

1 parent87186b2 commiteacb74cCopy full SHA for eacb74c

File tree

+20

-5

lines changed

+20

-5

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@ CHANGELOG`
`5`	`5`	`---`
`6`	`6`
`7`	`7`	* Allow custom meta location in`ResourceCheckerConfigCache`
	`8`	+* Allow custom meta location in`ConfigCache`
`8`	`9`
`9`	`10`	`7.0`
`10`	`11`	`---`

Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -26,19 +26,21 @@`
`26`	`26`	`class ConfigCacheextends ResourceCheckerConfigCache`
`27`	`27`	`{`
`28`	`28`	`/**`
`29`		`- * @param string $file The absolute cache path`
`30`		`- * @param bool $debug Whether debugging is enabled or not`
	`29`	`+ * @param string $file The absolute cache path`
	`30`	`+ * @param bool $debug Whether debugging is enabled or not`
	`31`	`+ * @param string\|null $metaFile The absolute path to the meta file`
`31`	`32`	`*/`
`32`	`33`	`publicfunction__construct(`
`33`	`34`	`string$file,`
`34`	`35`	`privatebool$debug,`
	`36`	`+ ?string$metaFile =null,`
`35`	`37`	`) {`
`36`	`38`	`$checkers = [];`
`37`	`39`	`if (true ===$this->debug) {`
`38`	`40`	`$checkers = [newSelfCheckingResourceChecker()];`
`39`	`41`	`}`
`40`	`42`
`41`		`-parent::__construct($file,$checkers);`
	`43`	`+parent::__construct($file,$checkers,$metaFile);`
`42`	`44`	`}`
`43`	`45`
`44`	`46`	`/**`

Lines changed: 14 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -13,21 +13,24 @@`
`13`	`13`
`14`	`14`	`usePHPUnit\Framework\TestCase;`
`15`	`15`	`useSymfony\Component\Config\ConfigCache;`
	`16`	`+useSymfony\Component\Config\Resource\FileResource;`
`16`	`17`	`useSymfony\Component\Config\Resource\SelfCheckingResourceChecker;`
`17`	`18`	`useSymfony\Component\Config\Tests\Resource\ResourceStub;`
`18`	`19`
`19`	`20`	`class ConfigCacheTestextends TestCase`
`20`	`21`	`{`
`21`	`22`	`privatestring$cacheFile;`
	`23`	`+privatestring$metaFile;`
`22`	`24`
`23`	`25`	`protectedfunctionsetUp():void`
`24`	`26`	`{`
`25`	`27`	`$this->cacheFile =tempnam(sys_get_temp_dir(),'config_');`
	`28`	`+$this->metaFile =tempnam(sys_get_temp_dir(),'config_');`
`26`	`29`	`}`
`27`	`30`
`28`	`31`	`protectedfunctiontearDown():void`
`29`	`32`	`{`
`30`		`-$files = [$this->cacheFile,$this->cacheFile.'.meta'];`
	`33`	`+$files = [$this->cacheFile,$this->cacheFile.'.meta',$this->metaFile];`
`31`	`34`
`32`	`35`	`foreach ($filesas$file) {`
`33`	`36`	`if (file_exists($file)) {`
`@@ -103,4 +106,14 @@ public static function debugModes(): array`
`103`	`106`	`[false],`
`104`	`107`	`];`
`105`	`108`	`}`
	`109`	`+`
	`110`	`+publicfunctiontestCacheWithCustomMetaFile()`
	`111`	`+ {`
	`112`	`+$this->assertStringEqualsFile($this->metaFile,'');`
	`113`	`+`
	`114`	`+$cache =newConfigCache($this->cacheFile,false,$this->metaFile);`
	`115`	`+$cache->write('foo', [newFileResource(__FILE__)]);`
	`116`	`+`
	`117`	`+$this->assertStringNotEqualsFile($this->metaFile,'');`
	`118`	`+ }`
`106`	`119`	`}`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,6 @@`
`20`	`20`	`class ResourceCheckerConfigCacheTestextends TestCase`
`21`	`21`	`{`
`22`	`22`	`privatestring$cacheFile;`
`23`		`-`
`24`	`23`	`privatestring$metaFile;`
`25`	`24`
`26`	`25`	`protectedfunctionsetUp():void`

Comments

(0)