Commitea05e7b

committed

deprecate calling createChildContext without the format parameter

1 parent77f642e commitea05e7bCopy full SHA for ea05e7b

File tree

-4

lines changed

-4

lines changed

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -486,8 +486,12 @@ protected function denormalizeParameter(\ReflectionClass $class, \ReflectionPara`
`486`	`486`	`*`
`487`	`487`	`* @internal`
`488`	`488`	`*/`
`489`		`-protectedfunctioncreateChildContext(array$parentContext,$attribute/, string $format = null /)`
	`489`	`+protectedfunctioncreateChildContext(array$parentContext,$attribute/,?string $format /)`
`490`	`490`	`{`
	`491`	`+if (\func_num_args() <3) {`
	`492`	+ @trigger_error(sprintf('Method %s::%s() will have a 3rd `?string $format` argument in version 5.0; not defining it is deprecated since Symfony 4.3.',\get_class($this),__FUNCTION__),E_USER_DEPRECATED);
	`493`	`+$format =null;`
	`494`	`+ }`
`491`	`495`	`if (isset($parentContext[self::ATTRIBUTES][$attribute])) {`
`492`	`496`	`$parentContext[self::ATTRIBUTES] =$parentContext[self::ATTRIBUTES][$attribute];`
`493`	`497`	`}else {`

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -512,18 +512,19 @@ private function isMaxDepthReached(array $attributesMetadata, string $class, str`
`512`	`512`	`* We must not mix up the attribute cache between parent and children.`
`513`	`513`	`*`
`514`	`514`	`* {@inheritdoc}`
	`515`	`+ *`
	`516`	`+ * @param string\|null $format`
`515`	`517`	`*/`
`516`		`-protectedfunctioncreateChildContext(array$parentContext,$attribute/, string $format = null /)`
	`518`	`+protectedfunctioncreateChildContext(array$parentContext,$attribute/,?string $format /)`
`517`	`519`	`{`
`518`	`520`	`if (\func_num_args() >=3) {`
`519`	`521`	`$format =\func_get_arg(2);`
`520`	`522`	`}else {`
`521`		`-//willbe deprecatedin version4`
	`523`	+@trigger_error(sprintf('Method %s::%s()willhave a 3rd `?string $format` argumentin version5.0; not defining it is deprecated since Symfony 4.3.',\get_class($this),__FUNCTION__),E_USER_DEPRECATED);
`522`	`524`	`$format =null;`
`523`	`525`	`}`
`524`	`526`
`525`	`527`	`$context =parent::createChildContext($parentContext,$attribute,$format);`
`526`		`-// format is already included in the cache_key of the parent.`
`527`	`528`	`$context['cache_key'] =$this->getCacheKey($format,$context);`
`528`	`529`
`529`	`530`	`return$context;`

Comments

(0)