Commite923f80

committed

typehint the port

1 parent899547b commite923f80Copy full SHA for e923f80

File tree

-8

lines changed

src/Symfony
- Bundle/SecurityBundle/DependencyInjection
  - SecurityExtension.php
- Component/HttpFoundation
  - RequestMatcher.php

-8

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -669,7 +669,7 @@ private function createExpression($container, $expression)`
`669`	`669`	`return$this->expressions[$id] =newReference($id);`
`670`	`670`	`}`
`671`	`671`
`672`		`-privatefunctioncreateRequestMatcher($container,$path =null,$host =null,$port =null,$methods =array(),$ip =null,array$attributes =array())`
	`672`	`+privatefunctioncreateRequestMatcher($container,$path =null,$host =null,int$port =null,$methods =array(),$ip =null,array$attributes =array())`
`673`	`673`	`{`
`674`	`674`	`if ($methods) {`
`675`	`675`	`$methods =array_map('strtoupper', (array)$methods);`

Lines changed: 3 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,8 +11,6 @@`
`11`	`11`
`12`	`12`	`namespaceSymfony\Component\HttpFoundation;`
`13`	`13`
`14`		`-usefunctionis_numeric;`
`15`		`-`
`16`	`14`	`/**`
`17`	`15`	`* RequestMatcher compares a pre-defined set of checks against a Request instance.`
`18`	`16`	`*`
`@@ -64,7 +62,7 @@ class RequestMatcher implements RequestMatcherInterface`
`64`	`62`	`* @param array $attributes`
`65`	`63`	`* @param string\|string[]\|null $schemes`
`66`	`64`	`*/`
`67`		`-publicfunction__construct(string$path =null,string$host =null,$methods =null,$ips =null,array$attributes =array(),$schemes =null,$port =null)`
	`65`	`+publicfunction__construct(string$path =null,string$host =null,$methods =null,$ips =null,array$attributes =array(),$schemes =null,int$port =null)`
`68`	`66`	`{`
`69`	`67`	`$this->matchPath($path);`
`70`	`68`	`$this->matchHost($host);`
`@@ -103,11 +101,9 @@ public function matchHost($regexp)`
`103`	`101`	`*`
`104`	`102`	`* @param int\|null $port The port number to connect to`
`105`	`103`	`*/`
`106`		`-publicfunctionmatchPort($port)`
	`104`	`+publicfunctionmatchPort(int$port):void`
`107`	`105`	`{`
`108`		`-$portInt = (int)$port;`
`109`		`-`
`110`		`-$this->port =is_numeric($port) \|\|$port ==$portInt ?$portInt :null;`
	`106`	`+$this->port =$port;`
`111`	`107`	`}`
`112`	`108`
`113`	`109`	`/**`

Comments

(0)