Commite76e3ef

committed

Rework to avoid refactoring of RetryableHttpClient

1 parent44b57b9 commite76e3efCopy full SHA for e76e3ef

File tree

-4

lines changed

src/Symfony
- Bundle/FrameworkBundle/DependencyInjection
  - FrameworkExtension.php
- Component/HttpClient
  - RetryableHttpClient.php

-4

lines changed

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2581,8 +2581,9 @@ private function registerRetryableHttpClient(array $options, string $name, Conta`
`2581`	`2581`	`$container`
`2582`	`2582`	`->register($name.'.retryable', RetryableHttpClient::class)`
`2583`	`2583`	`->setDecoratedService($name,null,10)// higher priority than TraceableHttpClient (5)`
`2584`		`- ->setArguments([newReference($name.'.retryable.inner'),$retryStrategy,$options['max_retries'],newReference('logger'),$baseUris])`
`2585`		`- ->addTag('monolog.logger', ['channel' =>'http_client']);`
	`2584`	`+ ->setArguments([newReference($name.'.retryable.inner'),$retryStrategy,$options['max_retries'],newReference('logger')])`
	`2585`	`+ ->addTag('monolog.logger', ['channel' =>'http_client'])`
	`2586`	`+ ->addMethodCall('withOptions', [['base_uri' =>$baseUris]],true);`
`2586`	`2587`	`}`
`2587`	`2588`
`2588`	`2589`	`privatefunctionregisterMailerConfiguration(array$config,ContainerBuilder$container,PhpFileLoader$loader,bool$webhookEnabled):void`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -40,13 +40,12 @@ class RetryableHttpClient implements HttpClientInterface, ResetInterface`
`40`	`40`	`/**`
`41`	`41`	`* @param int $maxRetries The maximum number of times to retry`
`42`	`42`	`*/`
`43`		`-publicfunction__construct(HttpClientInterface$client,RetryStrategyInterface$strategy =null,int$maxRetries =3,LoggerInterface$logger =null,array$baseUris = [])`
	`43`	`+publicfunction__construct(HttpClientInterface$client,RetryStrategyInterface$strategy =null,int$maxRetries =3,LoggerInterface$logger =null)`
`44`	`44`	`{`
`45`	`45`	`$this->client =$client;`
`46`	`46`	`$this->strategy =$strategy ??newGenericRetryStrategy();`
`47`	`47`	`$this->maxRetries =$maxRetries;`
`48`	`48`	`$this->logger =$logger ??newNullLogger();`
`49`		`-$this->baseUris =$baseUris;`
`50`	`49`	`}`
`51`	`50`
`52`	`51`	`publicfunctionwithOptions(array$options):static`

Comments

(0)