Commite223395

committed

[Debug] fixed case differences between PHP and HHVM (classes are case-insensitive anyway in PHP)

1 parent23acc24 commite223395Copy full SHA for e223395

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -254,7 +254,8 @@ public function testFatalErrorHandlers($error, $class, $translatedMessage)`
`254`	`254`	`$m->invoke($handler,$exceptionHandler,$error);`
`255`	`255`
`256`	`256`	`$this->assertInstanceof($class,$exceptionHandler->e);`
`257`		`-$this->assertSame($translatedMessage,$exceptionHandler->e->getMessage());`
	`257`	`+// class names are case insensitive and PHP/HHVM do not return the same`
	`258`	`+$this->assertSame(strtolower($translatedMessage),strtolower($exceptionHandler->e->getMessage()));`
`258`	`259`	`$this->assertSame($error['type'],$exceptionHandler->e->getSeverity());`
`259`	`260`	`$this->assertSame($error['file'],$exceptionHandler->e->getFile());`
`260`	`261`	`$this->assertSame($error['line'],$exceptionHandler->e->getLine());`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,8 @@ public function testUndefinedFunction($error, $translatedMessage)`
`25`	`25`	`$exception =$handler->handleError($error,newFatalErrorException('',0,$error['type'],$error['file'],$error['line']));`
`26`	`26`
`27`	`27`	`$this->assertInstanceof('Symfony\Component\Debug\Exception\UndefinedFunctionException',$exception);`
`28`		`-$this->assertSame($translatedMessage,$exception->getMessage());`
	`28`	`+// class names are case insensitive and PHP/HHVM do not return the same`
	`29`	`+$this->assertSame(strtolower($translatedMessage),strtolower($exception->getMessage()));`
`29`	`30`	`$this->assertSame($error['type'],$exception->getSeverity());`
`30`	`31`	`$this->assertSame($error['file'],$exception->getFile());`
`31`	`32`	`$this->assertSame($error['line'],$exception->getLine());`

Comments

(0)