Commitdce55f3

committed

Deprecated ROLE_PREVIOUS_ADMIN

1 parentff9b8da commitdce55f3Copy full SHA for dce55f3

File tree

+17

-1

lines changed

+17

-1

lines changed

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,10 @@ public function vote(TokenInterface $token, $subject, array $attributes)`
`40`	`40`	`continue;`
`41`	`41`	`}`
`42`	`42`
	`43`	`+if ('ROLE_PREVIOUS_ADMIN' ===$attribute) {`
	`44`	`+trigger_deprecation('symfony/security-core','5.1','The ROLE_PREVIOUS_ADMIN role is deprecated and will be removed in version 6.0, use the IS_IMPERSONATOR attribute instead.');`
	`45`	`+ }`
	`46`	`+`
`43`	`47`	`$result = VoterInterface::ACCESS_DENIED;`
`44`	`48`	`foreach ($rolesas$role) {`
`45`	`49`	`if ($attribute ===$role) {`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,17 @@ public function getVoteTests()`
`44`	`44`	`];`
`45`	`45`	`}`
`46`	`46`
	`47`	`+/**`
	`48`	`+ * @group legacy`
	`49`	`+ * @expectedDeprecation Since symfony/security-core 5.1: The ROLE_PREVIOUS_ADMIN role is deprecated and will be removed in version 6.0, use the IS_IMPERSONATOR attribute instead.`
	`50`	`+ */`
	`51`	`+publicfunctiontestDeprecatedRolePreviousAdmin()`
	`52`	`+ {`
	`53`	`+$voter =newRoleVoter();`
	`54`	`+`
	`55`	`+$voter->vote($this->getTokenWithRoleNames(['ROLE_USER','ROLE_PREVIOUS_ADMIN']),null, ['ROLE_PREVIOUS_ADMIN']);`
	`56`	`+ }`
	`57`	`+`
`47`	`58`	`protectedfunctiongetTokenWithRoleNames(array$roles)`
`48`	`59`	`{`
`49`	`60`	`$token =$this->getMockBuilder(AbstractToken::class)->getMock();`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,8 @@`
`18`	`18`	`"require": {`
`19`	`19`	`"php":"^7.2.5",`
`20`	`20`	`"symfony/event-dispatcher-contracts":"^1.1\|^2",`
`21`		`-"symfony/service-contracts":"^1.1.6\|^2"`
	`21`	`+"symfony/service-contracts":"^1.1.6\|^2",`
	`22`	`+"symfony/deprecation-contracts":"^2.1"`
`22`	`23`	`},`
`23`	`24`	`"require-dev": {`
`24`	`25`	`"psr/container":"^1.0",`

Comments

(0)