NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Commitdc8a43b

committed

bug#40416 FixConstraintViolation#getMessageTemplate() to always returnstring (Ocramius)

This PR was merged into the 5.2 branch.Discussion----------Fix `ConstraintViolation#getMessageTemplate()` to always return `string`| Q | A| ------------- | ---| Branch? | 5.2| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets || License | MIT| Doc PR |`ConstraintViolation#getMessageTemplate()`'s inherited signature states that `string` isto be returned by it at all times, yet the implementation returns `null` when no messagetemplate had been provided at instantiation.This patch obviates it, returning an empty string when themessage template is `null`.Ref:#40415 (comment)Commits-------72a464e Fix `ConstraintViolation#getMessageTemplate()` to always return `string`

2 parents16bacb1 +72a464e commitdc8a43bCopy full SHA for dc8a43b

File tree

2 files changed

+16

-1

lines changed

src/Symfony/Component/Validator
- ConstraintViolation.php
- Tests
  - ConstraintViolationTest.php

2 files changed

+16

-1

lines changed

`‎src/Symfony/Component/Validator/ConstraintViolation.php‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ public function __toString()`
`100`	`100`	`*/`
`101`	`101`	`publicfunctiongetMessageTemplate()`
`102`	`102`	`{`
`103`		`-return$this->messageTemplate;`
	`103`	`+return(string)$this->messageTemplate;`
`104`	`104`	`}`
`105`	`105`
`106`	`106`	`/**`

`‎src/Symfony/Component/Validator/Tests/ConstraintViolationTest.php‎`

Lines changed: 15 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -171,4 +171,19 @@ public function testRetrievedPropertyPathIsAStringEvenIfNotSet()`
`171`	`171`	`))->getPropertyPath()`
`172`	`172`	`);`
`173`	`173`	`}`
	`174`	`+`
	`175`	`+publicfunctiontestRetrievedMessageTemplateIsAStringEvenIfNotSet()`
	`176`	`+ {`
	`177`	`+self::assertSame(`
	`178`	`+'',`
	`179`	`+ (newConstraintViolation(`
	`180`	`+'irrelevant',`
	`181`	`+null,`
	`182`	`+ [],`
	`183`	`+'irrelevant',`
	`184`	`+'irrelevant',`
	`185`	`+null`
	`186`	`+ ))->getMessageTemplate()`
	`187`	`+ );`
	`188`	`+ }`
`174`	`189`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitdc8a43b

File tree

2 files changed

2 files changed

`‎src/Symfony/Component/Validator/ConstraintViolation.php‎`

`‎src/Symfony/Component/Validator/Tests/ConstraintViolationTest.php‎`

0 commit comments