Commitd8e74fc

committed

* Deprecated callingFormErrorIterator::children() if the current element is not iterable

1 parent49a076a commitd8e74fcCopy full SHA for d8e74fc

File tree

+13

-2

lines changed

+13

-2

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,11 @@ Finder`
`12`	`12`	* Deprecate`Comparator::setTarget()` and`Comparator::setOperator()`
`13`	`13`	* Add a constructor to`Comparator` that allows setting target and operator
`14`	`14`
	`15`	`+Form`
	`16`	`+------`
	`17`	`+`
	`18`	+* Deprecate calling`FormErrorIterator::children()` if the current element is not iterable.
	`19`	`+`
`15`	`20`	`FrameworkBundle`
`16`	`21`	`---------------`
`17`	`22`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -69,6 +69,7 @@ Finder`
`69`	`69`	`Form`
`70`	`70`	`----`
`71`	`71`
	`72`	+*`FormErrorIterator::children()` throws an exception if the current element is not iterable.
`72`	`73`	* The default value of the`rounding_mode` option of the`PercentType` has been changed to`\NumberFormatter::ROUND_HALFUP`.
`73`	`74`	* The default rounding mode of the`PercentToLocalizedStringTransformer` has been changed to`\NumberFormatter::ROUND_HALFUP`.
`74`	`75`	* Added the`getIsEmptyCallback()` method to the`FormConfigInterface`.

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@ CHANGELOG`
`4`	`4`	`5.4`
`5`	`5`	`---`
`6`	`6`
	`7`	+* Deprecate calling`FormErrorIterator::children()` if the current element is not iterable.
`7`	`8`	* Allow to pass`TranslatableMessage` objects to the`help` option
`8`	`9`
`9`	`10`	`5.3`

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@`
`13`	`13`
`14`	`14`	`useSymfony\Component\Form\Exception\BadMethodCallException;`
`15`	`15`	`useSymfony\Component\Form\Exception\InvalidArgumentException;`
	`16`	`+useSymfony\Component\Form\Exception\LogicException;`
`16`	`17`	`useSymfony\Component\Form\Exception\OutOfBoundsException;`
`17`	`18`	`useSymfony\Component\Validator\ConstraintViolation;`
`18`	`19`
`@@ -213,13 +214,16 @@ public function hasChildren()`
`213`	`214`	`}`
`214`	`215`
`215`	`216`	`/**`
`216`		`- * Alias of {@link current()}.`
`217`		`- *`
`218`	`217`	`* @return self`
`219`	`218`	`*/`
`220`	`219`	`#[\ReturnTypeWillChange]`
`221`	`220`	`publicfunctiongetChildren()`
`222`	`221`	`{`
	`222`	`+if (!$this->hasChildren()) {`
	`223`	`+trigger_deprecation('symfony/form','5.4','Calling "%s()" if the current element is not iterable is deprecated, call "%s" to get the current element.',__METHOD__,self::class.'::current()');`
	`224`	`+// throw new LogicException(sprintf('The current element is not iterable. Use "%s" to get the current element.', self::class.'::current()'));`
	`225`	`+ }`
	`226`	`+`
`223`	`227`	`returncurrent($this->errors);`
`224`	`228`	`}`
`225`	`229`

Comments

(0)