Commitd5e79b2

committed

[Cache] Use AdapterTestCase for new adapters

1 parentb6bbe43 commitd5e79b2Copy full SHA for d5e79b2

File tree

+12

-8

lines changed

+12

-8

lines changed

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,12 +11,11 @@`
`11`	`11`
`12`	`12`	`namespaceSymfony\Component\Cache\Tests\Adapter;`
`13`	`13`
`14`		`-useCache\IntegrationTests\CachePoolTest;`
`15`	`14`	`usePsr\Cache\CacheItemInterface;`
`16`	`15`	`useSymfony\Component\Cache\Adapter\NullAdapter;`
`17`	`16`	`useSymfony\Component\Cache\Adapter\PhpArrayAdapter;`
`18`	`17`
`19`		`-class PhpArrayAdapterTestextendsCachePoolTest`
	`18`	`+class PhpArrayAdapterTestextendsAdapterTestCase`
`20`	`19`	`{`
`21`	`20`	`protected$skippedTests =array(`
`22`	`21`	`'testBasicUsage' =>'PhpArrayAdapter is read-only.',`
`@@ -45,6 +44,8 @@ class PhpArrayAdapterTest extends CachePoolTest`
`45`	`44`	`'testHasItemInvalidKeys' =>'PhpArrayAdapter does not throw exceptions on invalid key.',`
`46`	`45`	`'testDeleteItemInvalidKeys' =>'PhpArrayAdapter does not throw exceptions on invalid key.',`
`47`	`46`	`'testDeleteItemsInvalidKeys' =>'PhpArrayAdapter does not throw exceptions on invalid key.',`
	`47`	`+`
	`48`	`+'testDefaultLifeTime' =>'PhpArrayAdapter does not allow configuring a default lifetime.',`
`48`	`49`	`);`
`49`	`50`
`50`	`51`	`privatestatic$file;`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,21 +11,21 @@`
`11`	`11`
`12`	`12`	`namespaceSymfony\Component\Cache\Tests\Adapter;`
`13`	`13`
`14`		`-useCache\IntegrationTests\CachePoolTest;`
`15`	`14`	`useSymfony\Component\Cache\Adapter\FilesystemAdapter;`
`16`	`15`	`useSymfony\Component\Cache\Adapter\PhpArrayAdapter;`
`17`	`16`
`18`	`17`	`/**`
`19`	`18`	`* @group time-sensitive`
`20`	`19`	`*/`
`21`		`-class PhpArrayAdapterWithFallbackTestextendsCachePoolTest`
	`20`	`+class PhpArrayAdapterWithFallbackTestextendsAdapterTestCase`
`22`	`21`	`{`
`23`	`22`	`protected$skippedTests =array(`
`24`	`23`	`'testGetItemInvalidKeys' =>'PhpArrayAdapter does not throw exceptions on invalid key.',`
`25`	`24`	`'testGetItemsInvalidKeys' =>'PhpArrayAdapter does not throw exceptions on invalid key.',`
`26`	`25`	`'testHasItemInvalidKeys' =>'PhpArrayAdapter does not throw exceptions on invalid key.',`
`27`	`26`	`'testDeleteItemInvalidKeys' =>'PhpArrayAdapter does not throw exceptions on invalid key.',`
`28`	`27`	`'testDeleteItemsInvalidKeys' =>'PhpArrayAdapter does not throw exceptions on invalid key.',`
	`28`	`+'testDefaultLifeTime' =>'PhpArrayAdapter does not allow configuring a default lifetime.',`
`29`	`29`	`);`
`30`	`30`
`31`	`31`	`privatestatic$file;`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,14 +11,17 @@`
`11`	`11`
`12`	`12`	`namespaceSymfony\Component\Cache\Tests\Adapter;`
`13`	`13`
`14`		`-useCache\IntegrationTests\CachePoolTest;`
`15`	`14`	`useSymfony\Component\Cache\Adapter\PhpFilesAdapter;`
`16`	`15`
`17`	`16`	`/**`
`18`	`17`	`* @group time-sensitive`
`19`	`18`	`*/`
`20`		`-class PhpFilesAdapterTestextendsCachePoolTest`
	`19`	`+class PhpFilesAdapterTestextendsAdapterTestCase`
`21`	`20`	`{`
	`21`	`+protected$skippedTests =array(`
	`22`	`+'testDefaultLifeTime' =>'PhpFilesAdapter does not allow configuring a default lifetime.',`
	`23`	`+ );`
	`24`	`+`
`22`	`25`	`publicfunctioncreateCachePool()`
`23`	`26`	`{`
`24`	`27`	`if (defined('HHVM_VERSION')) {`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -24,12 +24,12 @@ public static function setupBeforeClass()`
`24`	`24`	`self::$redis->connect('127.0.0.1');`
`25`	`25`	`}`
`26`	`26`
`27`		`-publicfunctioncreateCachePool()`
	`27`	`+publicfunctioncreateCachePool($defaultLifeTime =0)`
`28`	`28`	`{`
`29`	`29`	`if (defined('HHVM_VERSION')) {`
`30`	`30`	`$this->skippedTests['testDeferredSaveWithoutCommit'] ='Fails on HHVM';`
`31`	`31`	`}`
`32`	`32`
`33`		`-returnnewTagAwareRedisAdapter(self::$redis,str_replace('\\','.',__CLASS__));`
	`33`	`+returnnewTagAwareRedisAdapter(self::$redis,str_replace('\\','.',__CLASS__),$defaultLifeTime);`
`34`	`34`	`}`
`35`	`35`	`}`

Comments

(0)