Commitcadbed3

Harold Iedema

committed

[Console] Log exit codes as debug messages instead of errors

1 parent267b016 commitcadbed3Copy full SHA for cadbed3

File tree

-6

lines changed

src/Symfony/Component/Console
- EventListener
  - ErrorListener.php
- Tests/EventListener
  - ErrorListenerTest.php

-6

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -59,10 +59,10 @@ public function onConsoleTerminate(ConsoleTerminateEvent $event)`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`if (!$inputString =$this->getInputString($event)) {`
`62`		`-return$this->logger->error('The console exited with code "{code}"',array('code' =>$exitCode));`
	`62`	`+return$this->logger->debug('The console exited with code "{code}"',array('code' =>$exitCode));`
`63`	`63`	`}`
`64`	`64`
`65`		`-$this->logger->error('Command "{command}" exited with code "{code}"',array('command' =>$inputString,'code' =>$exitCode));`
	`65`	`+$this->logger->debug('Command "{command}" exited with code "{code}"',array('command' =>$inputString,'code' =>$exitCode));`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`publicstaticfunctiongetSubscribedEvents()`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ public function testOnConsoleTerminateForNonZeroExitCodeWritesToLog()`
`61`	`61`	`$logger =$this->getLogger();`
`62`	`62`	`$logger`
`63`	`63`	`->expects($this->once())`
`64`		`- ->method('error')`
	`64`	`+ ->method('debug')`
`65`	`65`	`->with('Command "{command}" exited with code "{code}"',array('command' =>'test:run','code' =>255))`
`66`	`66`	`;`
`67`	`67`
`@@ -74,7 +74,7 @@ public function testOnConsoleTerminateForZeroExitCodeDoesNotWriteToLog()`
`74`	`74`	`$logger =$this->getLogger();`
`75`	`75`	`$logger`
`76`	`76`	`->expects($this->never())`
`77`		`- ->method('error')`
	`77`	`+ ->method('debug')`
`78`	`78`	`;`
`79`	`79`
`80`	`80`	`$listener =newErrorListener($logger);`
`@@ -97,7 +97,7 @@ public function testAllKindsOfInputCanBeLogged()`
`97`	`97`	`$logger =$this->getLogger();`
`98`	`98`	`$logger`
`99`	`99`	`->expects($this->exactly(3))`
`100`		`- ->method('error')`
	`100`	`+ ->method('debug')`
`101`	`101`	`->with('Command "{command}" exited with code "{code}"',array('command' =>'test:run --foo=bar','code' =>255))`
`102`	`102`	`;`
`103`	`103`
`@@ -112,7 +112,7 @@ public function testCommandNameIsDisplayedForNonStringableInput()`
`112`	`112`	`$logger =$this->getLogger();`
`113`	`113`	`$logger`
`114`	`114`	`->expects($this->once())`
`115`		`- ->method('error')`
	`115`	`+ ->method('debug')`
`116`	`116`	`->with('Command "{command}" exited with code "{code}"',array('command' =>'test:run','code' =>255))`
`117`	`117`	`;`
`118`	`118`

Comments

(0)