Commitc965a17

authored and

Amrouche Hamza

committed

fix debug:autowiringcommand

1 parent9793522 commitc965a17Copy full SHA for c965a17

File tree

+37

-0

lines changed

src/Symfony/Bundle/FrameworkBundle
- Command
  - DebugAutowiringCommand.php
- Tests/Functional
  - DebugAutowiringCommandTest.php

+37

-0

lines changed

Lines changed: 12 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -100,6 +100,7 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`100`	`100`	`$hasAlias = [];`
`101`	`101`	`$all =$input->getOption('all');`
`102`	`102`	`$previousId ='-';`
	`103`	`+$serviceIdsNb =0;`
`103`	`104`	`foreach ($serviceIdsas$serviceId) {`
`104`	`105`	`$text = [];`
`105`	`106`	`if (0 !==strpos($serviceId,$previousId)) {`
`@@ -127,11 +128,22 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`127`	`128`	`$serviceLine .=' - <fg=magenta>deprecated</>';`
`128`	`129`	`}`
`129`	`130`	`}elseif (!$all) {`
	`131`	`+$serviceIdsNb++;`
`130`	`132`	`continue;`
`131`	`133`	`}`
`132`	`134`	`$text[] =$serviceLine;`
`133`	`135`	`$io->text($text);`
`134`	`136`	`}`
	`137`	`+`
	`138`	`+$io->newLine();`
	`139`	`+`
	`140`	`+if (0 <$serviceIdsNb) {`
	`141`	`+$io->text(sprintf('%s more concrete service%s would be displayed when adding the --all option.',$serviceIdsNb,$serviceIdsNb >1 ?'s' :''));`
	`142`	`+ }`
	`143`	`+if ($all) {`
	`144`	`+$io->text('Pro-tip: use interfaces in your type-hints instead of classes to benefit from the dependency inversion principle.');`
	`145`	`+ }`
	`146`	`+`
`135`	`147`	`$io->newLine();`
`136`	`148`	`}`
`137`	`149`

Lines changed: 25 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -72,4 +72,29 @@ public function testSearchNoResults()`
`72`	`72`	`$this->assertContains('No autowirable classes or interfaces found matching "foo_fake"',$tester->getErrorOutput());`
`73`	`73`	`$this->assertEquals(1,$tester->getStatusCode());`
`74`	`74`	`}`
	`75`	`+`
	`76`	`+publicfunctiontestSearchNotAliasedService()`
	`77`	`+ {`
	`78`	`+static::bootKernel(['test_case' =>'ContainerDebug','root_config' =>'config.yml']);`
	`79`	`+`
	`80`	`+$application =newApplication(static::$kernel);`
	`81`	`+$application->setAutoExit(false);`
	`82`	`+`
	`83`	`+$tester =newApplicationTester($application);`
	`84`	`+$tester->run(['command' =>'debug:autowiring','search' =>'redirect']);`
	`85`	`+`
	`86`	`+$this->assertContains(' more concrete service would be displayed when adding the --all option.',$tester->getDisplay());`
	`87`	`+ }`
	`88`	`+`
	`89`	`+publicfunctiontestSearchNotAliasedServiceWithAll()`
	`90`	`+ {`
	`91`	`+static::bootKernel(['test_case' =>'ContainerDebug','root_config' =>'config.yml']);`
	`92`	`+`
	`93`	`+$application =newApplication(static::$kernel);`
	`94`	`+$application->setAutoExit(false);`
	`95`	`+`
	`96`	`+$tester =newApplicationTester($application);`
	`97`	`+$tester->run(['command' =>'debug:autowiring','search' =>'redirect','--all' =>true]);`
	`98`	`+$this->assertContains('Pro-tip: use interfaces in your type-hints instead of classes to benefit from the dependency inversion principle.',$tester->getDisplay());`
	`99`	`+ }`
`75`	`100`	`}`

Comments

(0)