Commitc86c6e1

committed

[DI] fixed incorrect report for private services if required service does not exist

1 parentb60bb6e commitc86c6e1Copy full SHA for c86c6e1

File tree

+23

-1

lines changed

src/Symfony/Component/DependencyInjection
- Compiler
  - PassConfig.php
- Tests
  - ContainerBuilderTest.php

+23

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,7 @@ public function __construct()`
`74`	`74`	`$this->beforeRemovingPasses = [`
`75`	`75`	`-100 => [`
`76`	`76`	`newResolvePrivatesPass(),`
	`77`	`+newCheckExceptionOnInvalidReferenceBehaviorPass(),`
`77`	`78`	`],`
`78`	`79`	`];`
`79`	`80`
`@@ -88,7 +89,6 @@ public function __construct()`
`88`	`89`	`]];`
`89`	`90`
`90`	`91`	`$this->afterRemovingPasses = [[`
`91`		`-newCheckExceptionOnInvalidReferenceBehaviorPass(),`
`92`	`92`	`newResolveHotPathPass(),`
`93`	`93`	`]];`
`94`	`94`	`}`

Lines changed: 22 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1316,6 +1316,28 @@ public function testNoClassFromNsSeparatorId()`
`1316`	`1316`	`$container->compile();`
`1317`	`1317`	`}`
`1318`	`1318`
	`1319`	`+publicfunctiontestGetThrownServiceNotFoundExceptionWithCorrectServiceId()`
	`1320`	`+ {`
	`1321`	`+$this->expectException(ServiceNotFoundException::class);`
	`1322`	`+$this->expectExceptionMessage('The service "child_service" has a dependency on a non-existent service "non_existent_service".');`
	`1323`	`+`
	`1324`	`+$container =newContainerBuilder();`
	`1325`	`+$container->register('child_service', \stdClass::class)`
	`1326`	`+ ->setPublic(false)`
	`1327`	`+ ->addArgument([`
	`1328`	`+'non_existent' =>newReference('non_existent_service'),`
	`1329`	`+ ])`
	`1330`	`+ ;`
	`1331`	`+$container->register('parent_service', \stdClass::class)`
	`1332`	`+ ->setPublic(true)`
	`1333`	`+ ->addArgument([`
	`1334`	`+'child_service' =>newReference('child_service'),`
	`1335`	`+ ])`
	`1336`	`+ ;`
	`1337`	`+`
	`1338`	`+$container->compile();`
	`1339`	`+ }`
	`1340`	`+`
`1319`	`1341`	`publicfunctiontestServiceLocator()`
`1320`	`1342`	`{`
`1321`	`1343`	`$container =newContainerBuilder();`

Comments

(0)