Commitc7e01f4

committed

Implement PR suggestions

1 parenteb3e3b8 commitc7e01f4Copy full SHA for c7e01f4

File tree

-5

lines changed

-5

lines changed

Lines changed: 2 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ Form`
`10`	`10`	`----`
`11`	`11`
`12`	`12`	* Deprecated calling`FormRenderer::searchAndRenderBlock` for fields which were already rendered.
`13`		`- Instead of expecting such calls to return emptystring, check if the field has already been rendered.`
	`13`	`+ Instead of expecting such calls to return emptystrings, check if the field has already been rendered.`
`14`	`14`
`15`	`15`	`Before:`
`16`	`16`	```twig
`@@ -21,10 +21,8 @@ Form`
`21`	`21`
`22`	`22`	`After:`
`23`	`23`	```twig
`24`		`- {% for field in fieldsWithPotentialDuplicates %}`
`25`		`- {% if not field.rendered %}`
	`24`	`+ {% for field in fieldsWithPotentialDuplicates if not field.rendered %}`
`26`	`25`	`{{ form_widget(field) }}`
`27`		`- {% endif %}`
`28`	`26`	`{% endfor %}`
`29`	`27`	```
`30`	`28`	`Security`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ public function searchAndRenderBlock(FormView $view, $blockNameSuffix, array $va`
`133`	`133`
`134`	`134`	`if ($renderOnlyOnce &&$view->isRendered()) {`
`135`	`135`	`// This is not allowed, because it would result in rendering same IDs multiple times, which is not valid.`
`136`		`- @trigger_error(sprintf('You are calling "form_%s" for field "%s" which has already been rendered before. Trying to render fields which were already rendered is deprecated since Symfony 4.2 and will throw an exception in 5.0.',$blockNameSuffix,$view->vars['name']),E_USER_DEPRECATED);`
	`136`	`+ @trigger_error(sprintf('You are calling "form_%s" for field "%s" which has already been rendered before, trying to render fields which were already rendered is deprecated since Symfony 4.2 and will throw an exception in 5.0.',$blockNameSuffix,$view->vars['name']),E_USER_DEPRECATED);`
`137`	`137`	`// throw new BadMethodCallException(sprintf('Field "%s" has already been rendered. Save result of previous render call to variable and output that instead.', $view->vars['name']));`
`138`	`138`	`return'';`
`139`	`139`	`}`

Comments

(0)