Commitc6c56e5

committed

[Form] Fix BC break introduced in#14403

1 parentdd7e05d commitc6c56e5Copy full SHA for c6c56e5

File tree

-4

lines changed

-4

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -319,9 +319,10 @@`
`319`	`319`
`320`	`320`	`{%-blockwidget_attributes -%}`
`321`	`321`	`id="{{id }}" name="{{full_name }}"`
	`322`	`+ {%-ifread_only %} readonly="readonly"{%endif -%}`
`322`	`323`	`{%-ifdisabled %} disabled="disabled"{%endif -%}`
`323`	`324`	`{%-ifrequired %} required="required"{%endif -%}`
`324`		`- {%-forattrname,attrvalueinattr -%}`
	`325`	`+ {%-forattrname,attrvalueinattrif'readonly'!=attrname-%}`
`325`	`326`	`{{-"" -}}`
`326`	`327`	`{%-ifattrnamein ['placeholder','title'] -%}`
`327`	`328`	`{{-attrname }}="{{translation_domainissame as(false)?attrvalue:attrvalue\|trans({},translation_domain) }}"`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,9 @@`
`1`		`-id="<?phpecho$view->escape($id)?>" name="<?phpecho$view->escape($full_name)?>"<?phpif ($disabled):?> disabled="disabled"<?phpendif?>`
	`1`	`+id="<?phpecho$view->escape($id)?>" name="<?phpecho$view->escape($full_name)?>"<?phpif ($read_only):?> readonly="readonly"<?phpendif?>`
	`2`	`+`
	`3`	`+<?phpif ($disabled):?> disabled="disabled"<?phpendif?>`
`2`	`4`	`<?phpif ($required):?> required="required"<?phpendif?>`
`3`	`5`	`<?phpforeach ($attras$k =>$v):?>`
	`6`	`+<?phpif ('readonly' ===$k) {continue; }?>`
`4`	`7`	`<?phpif (in_array($k,array('placeholder','title'),true)):?>`
`5`	`8`	`<?phpprintf(' %s="%s"',$view->escape($k),$view->escape(false !==$translation_domain ?$view['translator']->trans($v,array(),$translation_domain) :$v))?>`
`6`	`9`	`<?phpelseif ($v ===true):?>`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2430,7 +2430,7 @@ public function testWidgetAttributes()`
`2430`	`2430`	`$html =$this->renderWidget($form->createView());`
`2431`	`2431`
`2432`	`2432`	`// compare plain HTML to check the whitespace`
`2433`		`-$this->assertSame('<input type="text" name="text"disabled="disabled" required="required" readonly="readonly" maxlength="10" pattern="\d+" data-foo="bar" value="value" />',$html);`
	`2433`	`+$this->assertSame('<input type="text" name="text"readonly="readonly" disabled="disabled" required="required" maxlength="10" pattern="\d+" data-foo="bar" value="value" />',$html);`
`2434`	`2434`	`}`
`2435`	`2435`
`2436`	`2436`	`publicfunctiontestWidgetAttributeNameRepeatedIfTrue()`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2373,7 +2373,7 @@ public function testWidgetAttributes()`
`2373`	`2373`	`$html =$this->renderWidget($form->createView());`
`2374`	`2374`
`2375`	`2375`	`// compare plain HTML to check the whitespace`
`2376`		`-$this->assertSame('<input type="text" name="text"disabled="disabled" required="required" readonly="readonly" maxlength="10" pattern="\d+" data-foo="bar" value="value" />',$html);`
	`2376`	`+$this->assertSame('<input type="text" name="text"readonly="readonly" disabled="disabled" required="required" maxlength="10" pattern="\d+" data-foo="bar" value="value" />',$html);`
`2377`	`2377`	`}`
`2378`	`2378`
`2379`	`2379`	`publicfunctiontestWidgetAttributeNameRepeatedIfTrue()`

Comments

(0)