Commitc51dda0

Robin Chalas

committed

[Console] Fix SymfonyQuestionHelper::askQuestion() with choice value as default

1 parent40fff43 commitc51dda0Copy full SHA for c51dda0

File tree

+14

-1

lines changed

+14

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ protected function writePrompt(OutputInterface $output, Question $question)`
`82`	`82`
`83`	`83`	`case$questioninstanceof ChoiceQuestion:`
`84`	`84`	`$choices =$question->getChoices();`
`85`		`-$text =sprintf(' <info>%s</info> [<comment>%s</comment>]:',$text, OutputFormatter::escape($choices[$default]));`
	`85`	`+$text =sprintf(' <info>%s</info> [<comment>%s</comment>]:',$text, OutputFormatter::escape(isset($choices[$default]) ?$choices[$default] :$default));`
`86`	`86`
`87`	`87`	`break;`
`88`	`88`

Lines changed: 13 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -75,6 +75,19 @@ public function testAskChoice()`
`75`	`75`	`$this->assertOutputContains('What is your favorite superhero? [Superman, Batman]',$output);`
`76`	`76`	`}`
`77`	`77`
	`78`	`+publicfunctiontestAskChoiceWithChoiceValueAsDefault()`
	`79`	`+ {`
	`80`	`+$questionHelper =newSymfonyQuestionHelper();`
	`81`	`+$helperSet =newHelperSet(array(newFormatterHelper()));`
	`82`	`+$questionHelper->setHelperSet($helperSet);`
	`83`	`+$questionHelper->setInputStream($this->getInputStream("Batman\n"));`
	`84`	`+$question =newChoiceQuestion('What is your favorite superhero?',array('Superman','Batman','Spiderman'),'Batman');`
	`85`	`+$question->setMaxAttempts(1);`
	`86`	`+`
	`87`	`+$this->assertSame('Batman',$questionHelper->ask($this->createInputInterfaceMock(),$output =$this->createOutputInterface(),$question));`
	`88`	`+$this->assertOutputContains('What is your favorite superhero? [Batman]',$output);`
	`89`	`+ }`
	`90`	`+`
`78`	`91`	`publicfunctiontestAskReturnsNullIfValidatorAllowsIt()`
`79`	`92`	`{`
`80`	`93`	`$questionHelper =newSymfonyQuestionHelper();`

Comments

(0)