Commitc4ee93d

committed

Configure NumberFormatter::ROUND_HALFUP as default rounding_mode

1 parentda0f36f commitc4ee93dCopy full SHA for c4ee93d

File tree

-50

lines changed

-50

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@ CHANGELOG`
`8`	`8`	* Remove`Symfony\Component\Form\Extension\Validator\Util\ServiceParams`
`9`	`9`	* Remove`FormPass` configuration
`10`	`10`	* Add`FormConfigInterface::getIsEmptyCallback()` and`FormConfigBuilderInterface::setIsEmptyCallback()`
	`11`	+* Configure`NumberFormatter::ROUND_HALFUP` as default value of`rounding_mode` option of the`PercentType`
`11`	`12`
`12`	`13`	`5.3`
`13`	`14`	`---`

Lines changed: 1 addition & 12 deletions

Original file line number	Diff line number	Diff line change
`@@ -53,11 +53,7 @@ public function configureOptions(OptionsResolver $resolver)`
`53`	`53`	`{`
`54`	`54`	`$resolver->setDefaults([`
`55`	`55`	`'scale' =>0,`
`56`		`-'rounding_mode' =>function (Options$options) {`
`57`		`-trigger_deprecation('symfony/form','5.1','Not configuring the "rounding_mode" option is deprecated. It will default to "\NumberFormatter::ROUND_HALFUP" in Symfony 6.0.');`
`58`		`-`
`59`		`-returnnull;`
`60`		`- },`
	`56`	`+'rounding_mode' => \NumberFormatter::ROUND_HALFUP,`
`61`	`57`	`'symbol' =>'%',`
`62`	`58`	`'type' =>'fractional',`
`63`	`59`	`'compound' =>false,`
`@@ -85,13 +81,6 @@ public function configureOptions(OptionsResolver $resolver)`
`85`	`81`	`]);`
`86`	`82`	`$resolver->setAllowedTypes('scale','int');`
`87`	`83`	`$resolver->setAllowedTypes('symbol', ['bool','string']);`
`88`		`-$resolver->setDeprecated('rounding_mode','symfony/form','5.1',function (Options$options,$roundingMode) {`
`89`		`-if (null ===$roundingMode) {`
`90`		`-return'Not configuring the "rounding_mode" option is deprecated. It will default to "\NumberFormatter::ROUND_HALFUP" in Symfony 6.0.';`
`91`		`- }`
`92`		`-`
`93`		`-return'';`
`94`		`- });`
`95`	`84`	`$resolver->setAllowedTypes('html5','bool');`
`96`	`85`	`}`
`97`	`86`

Lines changed: 0 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -42,11 +42,6 @@ public function testDebugDeprecatedDefaults()`
`42`	`42`	`$this->assertEquals(0,$ret,'Returns 0 in case of success');`
`43`	`43`	`$this->assertSame(<<<TXT`
`44`	`44`
`45`		`-Built-in form types (Symfony\Component\Form\Extension\Core\Type)`
`46`		`-----------------------------------------------------------------`
`47`		`-`
`48`		`- PercentType`
`49`		`-`
`50`	`45`	`Service form types`
`51`	`46`	`------------------`
`52`	`47`

Lines changed: 0 additions & 33 deletions

Original file line number	Diff line number	Diff line change
`@@ -82,37 +82,4 @@ public function testHtml5EnablesSpecificFormatting()`
`82`	`82`	`$this->assertSame('1234.56',$form->createView()->vars['value']);`
`83`	`83`	`$this->assertSame('number',$form->createView()->vars['type']);`
`84`	`84`	`}`
`85`		`-`
`86`		`-/**`
`87`		`- * @group legacy`
`88`		`- */`
`89`		`-publicfunctiontestSubmitWithoutRoundingMode()`
`90`		`- {`
`91`		`-$this->expectDeprecation('Since symfony/form 5.1: Not configuring the "rounding_mode" option is deprecated. It will default to "\NumberFormatter::ROUND_HALFUP" in Symfony 6.0.');`
`92`		`-`
`93`		`-$form =$this->factory->create(self::TESTED_TYPE,null, [`
`94`		`-'scale' =>2,`
`95`		`- ]);`
`96`		`-`
`97`		`-$form->submit('1.23456');`
`98`		`-`
`99`		`-$this->assertEquals(0.0123456,$form->getData());`
`100`		`- }`
`101`		`-`
`102`		`-/**`
`103`		`- * @group legacy`
`104`		`- */`
`105`		`-publicfunctiontestSubmitWithNullRoundingMode()`
`106`		`- {`
`107`		`-$this->expectDeprecation('Since symfony/form 5.1: Not configuring the "rounding_mode" option is deprecated. It will default to "\NumberFormatter::ROUND_HALFUP" in Symfony 6.0.');`
`108`		`-`
`109`		`-$form =$this->factory->create(self::TESTED_TYPE,null, [`
`110`		`-'rounding_mode' =>null,`
`111`		`-'scale' =>2,`
`112`		`- ]);`
`113`		`-`
`114`		`-$form->submit('1.23456');`
`115`		`-`
`116`		`-$this->assertEquals(0.0123456,$form->getData());`
`117`		`- }`
`118`	`85`	`}`

Comments

(0)