NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Commitc33c396

committed

bug#32299 [Lock] Stores must implementputOffExpiration (jderusse)

This PR was merged into the 4.2 branch.Discussion----------[Lock] Stores must implement `putOffExpiration`| Q | A| ------------- | ---| Branch? | 4.2| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | /| License | MIT| Doc PR | /Following#32198 (review) every stores MUST implement the method `putOffExpiration` either by ignoring the arguments (by design they lock forever) or using a mechanism to define the expiration.It was a mistake to add the dockblock `@throws NotSupportedException` tell me if it's a BC break, I'll create a dedicated PR for it.Commits-------c986c86 [Lock] Stores must implement `putOffExpiration`

2 parents34c50c0 +c986c86 commitc33c396Copy full SHA for c33c396

File tree

2 files changed

-2

lines changed

src/Symfony/Component/Lock
- StoreInterface.php
- Store
  - ZookeeperStore.php

2 files changed

-2

lines changed

`‎src/Symfony/Component/Lock/Store/ZookeeperStore.php‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ public function waitAndSave(Key $key)`
`91`	`91`	`*/`
`92`	`92`	`publicfunctionputOffExpiration(Key$key,$ttl)`
`93`	`93`	`{`
`94`		`-thrownewNotSupportedException();`
	`94`	`+// do nothing, zookeeper locks forever.`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`/**`

`‎src/Symfony/Component/Lock/StoreInterface.php‎`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,6 @@ public function waitAndSave(Key $key);`
`49`	`49`	`* @param float $ttl amount of seconds to keep the lock in the store`
`50`	`50`	`*`
`51`	`51`	`* @throws LockConflictedException`
`52`		`- * @throws NotSupportedException`
`53`	`52`	`*/`
`54`	`53`	`publicfunctionputOffExpiration(Key$key,$ttl);`
`55`	`54`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitc33c396

File tree

2 files changed

2 files changed

`‎src/Symfony/Component/Lock/Store/ZookeeperStore.php‎`

`‎src/Symfony/Component/Lock/StoreInterface.php‎`

0 commit comments