Commitc1bfaa1

committed

[Serializer] XmlEncoder: don't cast padded strings

1 parent5328c4b commitc1bfaa1Copy full SHA for c1bfaa1

File tree

+12

-1

lines changed

src/Symfony/Component/Serializer
- Encoder
  - XmlEncoder.php
- Tests/Encoder
  - XmlEncoderTest.php

+12

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -303,7 +303,7 @@ private function parseXmlAttributes(\DOMNode $node, array $context = [])`
`303`	`303`	`$typeCastAttributes =$this->resolveXmlTypeCastAttributes($context);`
`304`	`304`
`305`	`305`	`foreach ($node->attributesas$attr) {`
`306`		`-if (!is_numeric($attr->nodeValue) \|\| !$typeCastAttributes) {`
	`306`	`+if (!is_numeric($attr->nodeValue) \|\| !$typeCastAttributes \|\| (isset($attr->nodeValue[1]) &&'0' ===$attr->nodeValue[0])) {`
`307`	`307`	`$data['@'.$attr->nodeName] =$attr->nodeValue;`
`308`	`308`
`309`	`309`	`continue;`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -306,6 +306,17 @@ public function testNoTypeCastAttribute()`
`306`	`306`	`$this->assertSame($expected,$data);`
`307`	`307`	`}`
`308`	`308`
	`309`	`+publicfunctiontestDoesNotTypeCastStringsStartingWith0()`
	`310`	`+ {`
	`311`	`+$source =<<<XML`
	`312`	`+<?xml version="1.0"?>`
	`313`	`+<document a="018"></document>`
	`314`	`+XML;`
	`315`	`+`
	`316`	`+$data =$this->encoder->decode($source,'xml');`
	`317`	`+$this->assertSame('018',$data['@a']);`
	`318`	`+ }`
	`319`	`+`
`309`	`320`	`publicfunctiontestEncode()`
`310`	`321`	`{`
`311`	`322`	`$source =$this->getXmlSource();`

Comments

(0)