Commitbe5bff3

committed

[DI] Fix circular reference when using setters

1 parenta19d1e5 commitbe5bff3Copy full SHA for be5bff3

File tree

-7

lines changed

-7

lines changed

Lines changed: 3 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -353,22 +353,18 @@ private function analyzeCircularReferences(array $edges, &$checkedNodes, &$curre`
`353`	`353`	`$node =$edge->getDestNode();`
`354`	`354`	`$id =$node->getId();`
`355`	`355`
`356`		`-if (isset($checkedNodes[$id])) {`
`357`		`-continue;`
`358`		`- }`
`359`		`-$checkedNodes[$id] =true;`
`360`		`-`
`361`	`356`	`if ($node->getValue() && ($edge->isLazy() \|\|$edge->isWeak())) {`
`362`	`357`	`// no-op`
`363`	`358`	`}elseif (isset($currentPath[$id])) {`
`364`	`359`	`foreach (array_reverse($currentPath)as$parentId) {`
`365`	`360`	`$this->circularReferences[$parentId][$id] =$id;`
`366`	`361`	`$id =$parentId;`
`367`	`362`	`}`
`368`		`- }else {`
	`363`	`+ }elseif (!isset($checkedNodes[$id])) {`
	`364`	`+$checkedNodes[$id] =true;`
`369`	`365`	`$currentPath[$id] =$id;`
`370`	`366`	`$this->analyzeCircularReferences($node->getOutEdges(),$checkedNodes,$currentPath);`
`371`		`-array_pop($currentPath);`
	`367`	`+unset($currentPath[$id]);`
`372`	`368`	`}`
`373`	`369`	`}`
`374`	`370`	`}`

Comments

(0)