NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

Commitbcfacac

committed

minor#16749 [Form] Added getBlockPrefix() to ResolvedFormTypeInterface (webmozart)

This PR was merged into the 3.0-dev branch.Discussion----------[Form] Added getBlockPrefix() to ResolvedFormTypeInterface| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -This is the follow-up PR to#16724.If you call `$form->getConfig()->getType()`, all the methods of FormType should be usable. In that sense, ResolvedFormType is the developer-facing version of FormType.It is true that the same could be achieved with `getInnerType()`, but that method should be used in edge cases only as it clutters the code and makes it confusing to read:```php$blockPrefix = $form->getConfig()->getType()->getInnerType()->getBlockPrefix();```Commits-------7e89345 [Form] Added getBlockPrefix() to ResolvedFormTypeInterface

2 parentsab2044f +7e89345 commitbcfacacCopy full SHA for bcfacac

File tree

3 files changed

-12

lines changed

src/Symfony/Component/Form
- Extension/DataCollector/Proxy
  - ResolvedTypeDataCollectorProxy.php
- ResolvedFormType.php
- ResolvedFormTypeInterface.php

3 files changed

-12

lines changed

`‎src/Symfony/Component/Form/Extension/DataCollector/Proxy/ResolvedTypeDataCollectorProxy.php`

Lines changed: 1 addition & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -43,20 +43,12 @@ public function __construct(ResolvedFormTypeInterface $proxiedType, FormDataColl`
`43`	`43`	`$this->dataCollector =$dataCollector;`
`44`	`44`	`}`
`45`	`45`
`46`		`-/**`
`47`		`- * {@inheritdoc}`
`48`		`- */`
`49`		`-publicfunctiongetName()`
`50`		`- {`
`51`		`-return$this->proxiedType->getName();`
`52`		`- }`
`53`		`-`
`54`	`46`	`/**`
`55`	`47`	`* {@inheritdoc}`
`56`	`48`	`*/`
`57`	`49`	`publicfunctiongetBlockPrefix()`
`58`	`50`	`{`
`59`		`-returnmethod_exists($this->proxiedType,'getBlockPrefix') ?$this->proxiedType->getBlockPrefix() :$this->getName();`
	`51`	`+return$this->proxiedType->getBlockPrefix();`
`60`	`52`	`}`
`61`	`53`
`62`	`54`	`/**`

`‎src/Symfony/Component/Form/ResolvedFormType.php`

Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -56,9 +56,7 @@ public function __construct(FormTypeInterface $innerType, array $typeExtensions`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`/**`
`59`		`- * Returns the prefix of the template block name for this type.`
`60`		`- *`
`61`		`- * @return string The prefix of the template block name`
	`59`	`+ * {@inheritdoc}`
`62`	`60`	`*/`
`63`	`61`	`publicfunctiongetBlockPrefix()`
`64`	`62`	`{`

`‎src/Symfony/Component/Form/ResolvedFormTypeInterface.php`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,13 @@`
`20`	`20`	`*/`
`21`	`21`	`interface ResolvedFormTypeInterface`
`22`	`22`	`{`
	`23`	`+/**`
	`24`	`+ * Returns the prefix of the template block name for this type.`
	`25`	`+ *`
	`26`	`+ * @return string The prefix of the template block name`
	`27`	`+ */`
	`28`	`+publicfunctiongetBlockPrefix();`
	`29`	`+`
`23`	`30`	`/**`
`24`	`31`	`* Returns the parent type.`
`25`	`32`	`*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitbcfacac

File tree

3 files changed

3 files changed

`‎src/Symfony/Component/Form/Extension/DataCollector/Proxy/ResolvedTypeDataCollectorProxy.php`

`‎src/Symfony/Component/Form/ResolvedFormType.php`

`‎src/Symfony/Component/Form/ResolvedFormTypeInterface.php`

0 commit comments