Commitb5e6c99

Ivo

committed

[HttpFoundation] Fixed case-sensitive handling of cache-control header in RedirectResponse constructor.

1 parent1583b4f commitb5e6c99Copy full SHA for b5e6c99

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ public function __construct($url, $status = 302, $headers = [])`
`42`	`42`	`thrownew \InvalidArgumentException(sprintf('The HTTP status code is not a redirect ("%s" given).',$status));`
`43`	`43`	`}`
`44`	`44`
`45`		`-if (301 ==$status && !\array_key_exists('cache-control',$headers)) {`
	`45`	`+if (301 ==$status && !\array_key_exists('cache-control',array_change_key_case($headers, \CASE_LOWER))) {`
`46`	`46`	`$this->headers->remove('cache-control');`
`47`	`47`	`}`
`48`	`48`	`}`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -91,6 +91,10 @@ public function testCacheHeaders()`
`91`	`91`	`$this->assertFalse($response->headers->hasCacheControlDirective('no-cache'));`
`92`	`92`	`$this->assertTrue($response->headers->hasCacheControlDirective('max-age'));`
`93`	`93`
	`94`	`+$response =newRedirectResponse('foo.bar',301, ['Cache-Control' =>'max-age=86400']);`
	`95`	`+$this->assertFalse($response->headers->hasCacheControlDirective('no-cache'));`
	`96`	`+$this->assertTrue($response->headers->hasCacheControlDirective('max-age'));`
	`97`	`+`
`94`	`98`	`$response =newRedirectResponse('foo.bar',302);`
`95`	`99`	`$this->assertTrue($response->headers->hasCacheControlDirective('no-cache'));`
`96`	`100`	`}`

Comments

(0)