Commitb07d72c

committed

CheckExceptionOnInvalidReferenceBehaviorPass just after RemoveUnusedDefinitionsPass

1 parentf409d54 commitb07d72cCopy full SHA for b07d72c

File tree

+20

-1

lines changed

src/Symfony/Component/DependencyInjection
- Compiler
  - PassConfig.php
- Tests
  - ContainerBuilderTest.php

+20

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,6 @@ public function __construct()`
`74`	`74`	`$this->beforeRemovingPasses = [`
`75`	`75`	`-100 => [`
`76`	`76`	`newResolvePrivatesPass(),`
`77`		`-newCheckExceptionOnInvalidReferenceBehaviorPass(),`
`78`	`77`	`],`
`79`	`78`	`];`
`80`	`79`
`@@ -83,6 +82,7 @@ public function __construct()`
`83`	`82`	`newReplaceAliasByActualDefinitionPass(),`
`84`	`83`	`newRemoveAbstractDefinitionsPass(),`
`85`	`84`	`newRemoveUnusedDefinitionsPass(),`
	`85`	`+newCheckExceptionOnInvalidReferenceBehaviorPass(),`
`86`	`86`	`newInlineServiceDefinitionsPass(newAnalyzeServiceReferencesPass()),`
`87`	`87`	`newAnalyzeServiceReferencesPass(),`
`88`	`88`	`newDefinitionErrorExceptionPass(),`

Lines changed: 19 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1338,6 +1338,25 @@ public function testGetThrownServiceNotFoundExceptionWithCorrectServiceId()`
`1338`	`1338`	`$container->compile();`
`1339`	`1339`	`}`
`1340`	`1340`
	`1341`	`+publicfunctiontestUnusedServiceRemovedByPassAndServiceNotFoundExceptionWasNotThrown()`
	`1342`	`+ {`
	`1343`	`+$container =newContainerBuilder();`
	`1344`	`+$container->register('service', \stdClass::class)`
	`1345`	`+ ->setPublic(false)`
	`1346`	`+ ->addArgument([`
	`1347`	`+'non_existent_service' =>newReference('non_existent_service'),`
	`1348`	`+ ])`
	`1349`	`+ ;`
	`1350`	`+`
	`1351`	`+try {`
	`1352`	`+$container->compile();`
	`1353`	`+ }catch (ServiceNotFoundException$e) {`
	`1354`	`+$this->fail('Should not be thrown');`
	`1355`	`+ }`
	`1356`	`+`
	`1357`	`+$this->assertTrue(true);`
	`1358`	`+ }`
	`1359`	`+`
`1341`	`1360`	`publicfunctiontestServiceLocator()`
`1342`	`1361`	`{`
`1343`	`1362`	`$container =newContainerBuilder();`

Comments

(0)