Commitad81c6e

committed

Fixing missing abstract attribute in XmlDumper

Caused mis-reporting of abstract key (always no) in debug:container

1 parent49d6604 commitad81c6eCopy full SHA for ad81c6e

File tree

+30

-0

lines changed

+30

-0

lines changed

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -191,6 +191,10 @@ private function addService($definition, $id, \DOMElement $parent)`
`191`	`191`	`$service->appendChild($factory);`
`192`	`192`	`}`
`193`	`193`
	`194`	`+if ($definition->isAbstract()) {`
	`195`	`+$service->setAttribute('abstract','true');`
	`196`	`+ }`
	`197`	`+`
`194`	`198`	`if ($callable =$definition->getConfigurator()) {`
`195`	`199`	`$configurator =$this->document->createElement('configurator');`
`196`	`200`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -184,4 +184,12 @@ public function testDumpInlinedServices()`
`184`	`184`
`185`	`185`	`$this->assertEquals(file_get_contents(self::$fixturesPath.'/xml/services21.xml'),$dumper->dump());`
`186`	`186`	`}`
	`187`	`+`
	`188`	`+publicfunctiontestDumpAbstractServices()`
	`189`	`+ {`
	`190`	`+$container =includeself::$fixturesPath.'/containers/container-abstract.php';`
	`191`	`+$dumper =newXmlDumper($container);`
	`192`	`+`
	`193`	`+$this->assertEquals(file_get_contents(self::$fixturesPath.'/xml/services-abstract.xml'),$dumper->dump());`
	`194`	`+ }`
`187`	`195`	`}`

Lines changed: 12 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,12 @@`
	`1`	`+<?php`
	`2`	`+`
	`3`	`+useSymfony\Component\DependencyInjection\ContainerBuilder;`
	`4`	`+`
	`5`	`+$container =newContainerBuilder();`
	`6`	`+`
	`7`	`+$container`
	`8`	`+ ->register('foo','Foo')`
	`9`	`+ ->setAbstract(true)`
	`10`	`+;`
	`11`	`+`
	`12`	`+return$container;`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,6 @@`
	`1`	`+<?xml version="1.0" encoding="utf-8"?>`
	`2`	`+<containerxmlns="http://symfony.com/schema/dic/services"xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">`
	`3`	`+ <services>`
	`4`	`+ <serviceid="foo"class="Foo"abstract="true"/>`
	`5`	`+ </services>`
	`6`	`+</container>`

Comments

(0)