NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

Commitab9e844

committed

[HttpFoundation] Deprecate passing invalid URI to Request::create

Fixes:#47084Passing an invalid URI to Request::create triggers an undefined codepath. In PHP7 the false value returned by parse_url would quietly betreated as a an array through type coercion leading to unexpectedresults. In PHP8 this triggers a deprecation exposing the bug.

1 parente16aea4 commitab9e844Copy full SHA for ab9e844

File tree

2 files changed

+13

-0

lines changed

src/Symfony/Component/HttpFoundation
- Request.php
- Tests
  - RequestTest.php

2 files changed

+13

-0

lines changed

`‎src/Symfony/Component/HttpFoundation/Request.php`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -342,6 +342,10 @@ public static function create(string $uri, string $method = 'GET', array $parame`
`342`	`342`	`$server['REQUEST_METHOD'] =strtoupper($method);`
`343`	`343`
`344`	`344`	`$components =parse_url($uri);`
	`345`	`+if (false ===$components) {`
	`346`	`+trigger_deprecation('symfony/http-foundation','6.3','Calling "%s()" without an invalid URI is deprecated.',__METHOD__ );`
	`347`	`+$components = [];`
	`348`	`+ }`
`345`	`349`	`if (isset($components['host'])) {`
`346`	`350`	`$server['SERVER_NAME'] =$components['host'];`
`347`	`351`	`$server['HTTP_HOST'] =$components['host'];`

`‎src/Symfony/Component/HttpFoundation/Tests/RequestTest.php`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2554,6 +2554,15 @@ public function testReservedFlags()`
`2554`	`2554`	`$this->assertNotSame(0b10000000,$value,sprintf('The constant "%s" should not use the reserved value "0b10000000".',$constant));`
`2555`	`2555`	`}`
`2556`	`2556`	`}`
	`2557`	`+`
	`2558`	`+/**`
	`2559`	`+ * @group legacy`
	`2560`	`+ */`
	`2561`	`+publicfunctiontestInvalidUriCreationDeprecated()`
	`2562`	`+ {`
	`2563`	`+$this->expectDeprecation('Since symfony/http-foundation 6.3: Calling "Symfony\Component\HttpFoundation\Request::create()" without an invalid URI is deprecated.');`
	`2564`	`+ Request::create('/invalid-path:123');`
	`2565`	`+ }`
`2557`	`2566`	`}`
`2558`	`2567`
`2559`	`2568`	`class RequestContentProxyextends Request`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitab9e844

File tree

2 files changed

2 files changed

`‎src/Symfony/Component/HttpFoundation/Request.php`

`‎src/Symfony/Component/HttpFoundation/Tests/RequestTest.php`

0 commit comments