Commitab9dec3

committed

accepts floats for input="string" in NumberType

1 parent030396a commitab9dec3Copy full SHA for ab9dec3

File tree

+19

-0

lines changed

src/Symfony/Component/Form
- Extension/Core/Type
  - NumberType.php
- Tests/Extension/Core/Type
  - NumberTypeTest.php

+19

-0

lines changed

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@`
`12`	`12`	`namespaceSymfony\Component\Form\Extension\Core\Type;`
`13`	`13`
`14`	`14`	`useSymfony\Component\Form\AbstractType;`
	`15`	`+useSymfony\Component\Form\CallbackTransformer;`
`15`	`16`	`useSymfony\Component\Form\Exception\LogicException;`
`16`	`17`	`useSymfony\Component\Form\Extension\Core\DataTransformer\NumberToLocalizedStringTransformer;`
`17`	`18`	`useSymfony\Component\Form\Extension\Core\DataTransformer\StringToFloatTransformer;`
`@@ -37,6 +38,14 @@ public function buildForm(FormBuilderInterface $builder, array $options)`
`37`	`38`
`38`	`39`	`if ('string' ===$options['input']) {`
`39`	`40`	`$builder->addModelTransformer(newStringToFloatTransformer($options['scale']));`
	`41`	`+$builder->addModelTransformer(newCallbackTransformer(`
	`42`	`+function ($value) {`
	`43`	`+return\is_float($value) ? (string)$value :$value;`
	`44`	`+ },`
	`45`	`+function ($value) {`
	`46`	`+return$value;`
	`47`	`+ }`
	`48`	`+ ));`
`40`	`49`	`}`
`41`	`50`	`}`
`42`	`51`

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -77,6 +77,16 @@ public function testDefaultFormattingWithScaleAndStringInput(): void`
`77`	`77`	`$this->assertSame('12345,68',$form->createView()->vars['value']);`
`78`	`78`	`}`
`79`	`79`
	`80`	`+publicfunctiontestStringInputWithFloatData():void`
	`81`	`+ {`
	`82`	`+$form =$this->factory->create(static::TESTED_TYPE,12345.6789, [`
	`83`	`+'input' =>'string',`
	`84`	`+'scale' =>2,`
	`85`	`+ ]);`
	`86`	`+`
	`87`	`+$this->assertSame('12345,68',$form->createView()->vars['value']);`
	`88`	`+ }`
	`89`	`+`
`80`	`90`	`publicfunctiontestDefaultFormattingWithRounding():void`
`81`	`91`	`{`
`82`	`92`	`$form =$this->factory->create(static::TESTED_TYPE,null, ['scale' =>0,'rounding_mode' => \NumberFormatter::ROUND_UP]);`

Comments

(0)