Commita00dc82

committed

[Security] Fix triggering session tracking from ContextListener

1 parent9fd383a commita00dc82Copy full SHA for a00dc82

File tree

-0

lines changed

src/Symfony/Component/Security/Http
- Firewall
  - ContextListener.php
- Tests/Firewall
  - ContextListenerTest.php

-0

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -164,6 +164,7 @@ public function onKernelResponse(ResponseEvent $event): void`
`164`	`164`	`$session =$request->getSession();`
`165`	`165`	`$sessionId =$session->getId();`
`166`	`166`	`$usageIndexValue =$sessioninstanceof Session ?$usageIndexReference = &$session->getUsageIndex() :null;`
	`167`	`+$usageIndexReference = \PHP_INT_MIN;`
`167`	`168`	`$token =$this->tokenStorage->getToken();`
`168`	`169`
`169`	`170`	`if (!$this->trustResolver->isAuthenticated($token)) {`
`@@ -178,6 +179,8 @@ public function onKernelResponse(ResponseEvent $event): void`
`178`	`179`
`179`	`180`	`if ($this->sessionTrackerEnabler &&$session->getId() ===$sessionId) {`
`180`	`181`	`$usageIndexReference =$usageIndexValue;`
	`182`	`+ }else {`
	`183`	`+$usageIndexReference =$usageIndexReference - \PHP_INT_MIN +$usageIndexValue;`
`181`	`184`	`}`
`182`	`185`	`}`
`183`	`186`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -323,6 +323,8 @@ public function testSessionIsNotReported()`
`323`	`323`
`324`	`324`	`$listener =newContextListener($tokenStorage, [],'context_key',null,null,null,$tokenStorage->getToken(...));`
`325`	`325`	`$listener(newRequestEvent($this->createMock(HttpKernelInterface::class),$request, HttpKernelInterface::MAIN_REQUEST));`
	`326`	`+`
	`327`	`+$listener->onKernelResponse(newResponseEvent($this->createMock(HttpKernelInterface::class),$request, HttpKernelInterface::MAIN_REQUEST,newResponse()));`
`326`	`328`	`}`
`327`	`329`
`328`	`330`	`publicfunctiontestOnKernelResponseRemoveListener()`

Comments

(0)