NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Commita004fc7

committed

minor#18932 Improve memory efficiency (Dword123)

This PR was merged into the 2.7 branch.Discussion----------Improve memory efficiency| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |This avoids concatenating `$message` and `PHP_EOL` (if necessary) as a new value, greatly improving memory efficiency for large `$message`s.Commits-------c1df9f2 Improve memory efficiency

2 parents9d79a40 +c1df9f2 commita004fc7Copy full SHA for a004fc7

File tree

1 file changed

-1

lines changed

src/Symfony/Component/Console/Output
- StreamOutput.php

1 file changed

-1

lines changed

`‎src/Symfony/Component/Console/Output/StreamOutput.php‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ public function getStream()`
`70`	`70`	`*/`
`71`	`71`	`protectedfunctiondoWrite($message,$newline)`
`72`	`72`	`{`
`73`		`-if (false === @fwrite($this->stream,$message.($newline?PHP_EOL :''))) {`
	`73`	`+if (false === @fwrite($this->stream,$message) \|\|($newline&& (false === @fwrite($this->stream,PHP_EOL)))) {`
`74`	`74`	`// should never happen`
`75`	`75`	`thrownew \RuntimeException('Unable to write output.');`
`76`	`76`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commita004fc7

File tree

1 file changed

1 file changed

`‎src/Symfony/Component/Console/Output/StreamOutput.php‎`

0 commit comments