Commit9fe11c6

committed

deprecate using invalid names for buttons

1 parent7377265 commit9fe11c6Copy full SHA for 9fe11c6

File tree

+45

-1

lines changed

+45

-1

lines changed

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,11 @@`
	`1`	`+UPGRADE FROM 4.2 to 4.3`
	`2`	`+=======================`
	`3`	`+`
	`4`	`+Form`
	`5`	`+----`
	`6`	`+`
	`7`	`+* Using names for buttons that do not start with a letter, a digit, or an underscore is deprecated and will lead to an`
	`8`	`+ exception in 5.0.`
	`9`	`+`
	`10`	`+* Using names for buttons that do not contain only letters, digits, underscores, hyphens, and colons is deprecated and`
	`11`	`+ will lead to an exception in 5.0.`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -72,6 +72,11 @@ Finder`
`72`	`72`	`Form`
`73`	`73`	`----`
`74`	`74`
	`75`	`+* Using names for buttons that do not start with a letter, a digit, or an underscore leads to an exception.`
	`76`	`+`
	`77`	`+* Using names for buttons that do not contain only letters, digits, underscores, hyphens, and colons leads to an`
	`78`	`+ exception.`
	`79`	`+`
`75`	`80`	* The`getExtendedType()` method was removed from the`FormTypeExtensionInterface`. It is replaced by the the static
`76`	`81`	`getExtendedTypes()` method which must return an iterable of extended types.
`77`	`82`

Lines changed: 12 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -63,6 +63,18 @@ public function __construct(?string $name, array $options = array())`
`63`	`63`
`64`	`64`	`$this->name =$name;`
`65`	`65`	`$this->options =$options;`
	`66`	`+`
	`67`	`+if (\preg_match('/^([^a-z0-9_].)?(.[^a-zA-Z0-9_\-:].*)?$/D',$name,$matches)) {`
	`68`	`+if (isset($matches[1])) {`
	`69`	`+ @trigger_error(sprintf('Using names for buttons that do not start with a letter, a digit, or an underscore is deprecated since Symfony 4.3 and will trigger an exception in 5.0 ("%s" given).',$name),E_USER_DEPRECATED);`
	`70`	`+ }`
	`71`	`+if (isset($matches[2])) {`
	`72`	`+ @trigger_error(sprintf('Using names for buttons that do not contain only letters, digits, underscores ("_"), hyphens ("-") and colons (":") ("%s" given) is deprecated since Symfony 4.3 and will trigger an exception in 5.0.',$name),E_USER_DEPRECATED);`
	`73`	`+ }`
	`74`	`+ }`
	`75`	`+`
	`76`	`+// to be added in 5.0`
	`77`	`+// FormConfigBuilder::validateName($name);`
`66`	`78`	`}`
`67`	`79`
`68`	`80`	`/**`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,15 @@`
`1`	`1`	`CHANGELOG`
`2`	`2`	`=========`
`3`	`3`
	`4`	`+4.3.0`
	`5`	`+-----`
	`6`	`+`
	`7`	`+* Using names for buttons that do not start with a letter, a digit, or an underscore is deprecated and will lead to an`
	`8`	`+ exception in 5.0.`
	`9`	`+`
	`10`	`+* Using names for buttons that do not contain only letters, digits, underscores, hyphens, and colons is deprecated and`
	`11`	`+ will lead to an exception in 5.0.`
	`12`	`+`
`4`	`13`	`4.2.0`
`5`	`14`	`-----`
`6`	`15`

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,6 @@ public function getValidNames()`
`28`	`28`	`array('foo'),`
`29`	`29`	`array('0'),`
`30`	`30`	`array(0),`
`31`		`-array('button[]'),`
`32`	`31`	`);`
`33`	`32`	`}`
`34`	`33`
`@@ -40,6 +39,14 @@ public function testValidNames($name)`
`40`	`39`	`$this->assertInstanceOf('\Symfony\Component\Form\ButtonBuilder',newButtonBuilder($name));`
`41`	`40`	`}`
`42`	`41`
	`42`	`+/**`
	`43`	`+ * @group legacy`
	`44`	`+ */`
	`45`	`+publicfunctiontestNameContainingIllegalCharacters()`
	`46`	`+ {`
	`47`	`+$this->assertInstanceOf('\Symfony\Component\Form\ButtonBuilder',newButtonBuilder('button[]'));`
	`48`	`+ }`
	`49`	`+`
`43`	`50`	`publicfunctiongetInvalidNames()`
`44`	`51`	`{`
`45`	`52`	`returnarray(`

Comments

(0)