Commit93fcdb8

committed

[PasswordHasher] Skip test on nul byte for PHP versions that doesn't support it with Bcrypt

1 parentfbc47bc commit93fcdb8Copy full SHA for 93fcdb8

File tree

+14

-0

lines changed

+14

-0

lines changed

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -98,6 +98,13 @@ public function testBcryptWithLongPassword()`
`98`	`98`	`$this->assertTrue($hasher->verify($hasher->hash($plainPassword),$plainPassword));`
`99`	`99`	`}`
`100`	`100`
	`101`	`+/**`
	`102`	`+ * "password_hash()" does not accept passwords containing NUL bytes prior to PHP 8.2`
	`103`	+ * and throws a ValueError, thus this test is skipped because `$hasher->verify()` will
	`104`	`+ * not be executed.`
	`105`	`+ *`
	`106`	`+ * @requires PHP >= 8.2`
	`107`	`+ */`
`101`	`108`	`publicfunctiontestBcryptWithNulByte()`
`102`	`109`	`{`
`103`	`110`	`$hasher =newNativePasswordHasher(null,null,4, \PASSWORD_BCRYPT);`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -73,6 +73,13 @@ public function testBcryptWithLongPassword()`
`73`	`73`	`$this->assertTrue($hasher->verify((newNativePasswordHasher(null,null,4, \PASSWORD_BCRYPT))->hash($plainPassword),$plainPassword));`
`74`	`74`	`}`
`75`	`75`
	`76`	`+/**`
	`77`	`+ * "password_hash()" does not accept passwords containing NUL bytes prior to PHP 8.2`
	`78`	+ * and throws a ValueError, thus this test is skipped because `$hasher->verify()` will
	`79`	`+ * not be executed.`
	`80`	`+ *`
	`81`	`+ * @requires PHP >= 8.2`
	`82`	`+ */`
`76`	`83`	`publicfunctiontestBcryptWithNulByte()`
`77`	`84`	`{`
`78`	`85`	`$hasher =newSodiumPasswordHasher(null,null);`

Comments

(0)