Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit92bc13a

Browse files
committed
minor#42820 remove unneeded eval given PHP 8 in 6.0 (Tobion)
This PR was merged into the 6.0 branch.Discussion----------remove unneeded eval given PHP 8 in 6.0| Q | A| ------------- | ---| Branch? | 6.0| Bug fix? | no| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets || License | MIT| Doc PR |Remove eval() added in#42039 for 6.0Commits-------1a3ec8c remove unneeded eval given PHP 8 in 6.0
2 parents3774892 +1a3ec8c commit92bc13a

File tree

3 files changed

+8
-11
lines changed

3 files changed

+8
-11
lines changed

‎src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -557,7 +557,7 @@ public function load(array $configs, ContainerBuilder $container)
557557
$container->registerForAutoconfiguration(LoggerAwareInterface::class)
558558
->addMethodCall('setLogger', [newReference('logger')]);
559559

560-
$container->registerAttributeForAutoconfiguration(AsEventListener::class,staticfunction (ChildDefinition$definition,AsEventListener$attribute,\Reflector$reflector) {
560+
$container->registerAttributeForAutoconfiguration(AsEventListener::class,staticfunction (ChildDefinition$definition,AsEventListener$attribute,\ReflectionClass|\ReflectionMethod$reflector) {
561561
$tagAttributes =get_object_vars($attribute);
562562
if ($reflectorinstanceof \ReflectionMethod) {
563563
if (isset($tagAttributes['method'])) {

‎src/Symfony/Component/DependencyInjection/Tests/Compiler/IntegrationTest.php‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -754,8 +754,7 @@ static function (ChildDefinition $definition, CustomParameterAttribute $attribut
754754
);
755755
$container->registerAttributeForAutoconfiguration(
756756
CustomAnyAttribute::class,
757-
eval(<<<'PHP'
758-
return static function (\Symfony\Component\DependencyInjection\ChildDefinition $definition, \Symfony\Component\DependencyInjection\Tests\Fixtures\Attribute\CustomAnyAttribute $attribute, \ReflectionClass|\ReflectionMethod|\ReflectionProperty|\ReflectionParameter $reflector) {
757+
staticfunction (ChildDefinition$definition,CustomAnyAttribute$attribute,\ReflectionClass|\ReflectionMethod|\ReflectionProperty|\ReflectionParameter$reflector) {
759758
$tagAttributes =get_object_vars($attribute);
760759
if ($reflectorinstanceof \ReflectionClass) {
761760
$tagAttributes['class'] =$reflector->getName();
@@ -768,9 +767,8 @@ static function (ChildDefinition $definition, CustomParameterAttribute $attribut
768767
}
769768

770769
$definition->addTag('app.custom_tag',$tagAttributes);
771-
};
772-
PHP
773-
));
770+
}
771+
);
774772

775773
$container->register(TaggedService4::class)
776774
->setPublic(true)

‎src/Symfony/Component/EventDispatcher/Tests/DependencyInjection/RegisterListenersPassTest.php‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -285,16 +285,15 @@ public function testTaggedMultiEventListener()
285285
}
286286

287287
$container =newContainerBuilder();
288-
$container->registerAttributeForAutoconfiguration(AsEventListener::class,eval(<<<'PHP'
289-
returnstatic function (\Symfony\Component\DependencyInjection\ChildDefinition $definition,\Symfony\Component\EventDispatcher\Attribute\AsEventListener $attribute, \ReflectionClass|\ReflectionMethod $reflector): void {
288+
$container->registerAttributeForAutoconfiguration(AsEventListener::class,
289+
staticfunction (ChildDefinition$definition,AsEventListener$attribute,\ReflectionClass|\ReflectionMethod$reflector):void {
290290
$tagAttributes =get_object_vars($attribute);
291291
if ($reflectorinstanceof \ReflectionMethod) {
292292
$tagAttributes['method'] =$reflector->getName();
293293
}
294294
$definition->addTag('kernel.event_listener',$tagAttributes);
295-
};
296-
PHP
297-
));
295+
}
296+
);
298297

299298
$container->register('foo', TaggedMultiListener::class)->setAutoconfigured(true);
300299
$container->register('event_dispatcher', \stdClass::class);

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp