Commit92b0da1

authored and

committed

[PropertyInfo] Add PHP 8.0 promoted properties@param mutation support toPhpDocExtractor

1 parent77ec2ad commit92b0da1Copy full SHA for 92b0da1

File tree

+40

-13

lines changed

+40

-13

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@ CHANGELOG`
`5`	`5`	`---`
`6`	`6`
`7`	`7`	`* Add support for phpDocumentor and PHPStan pseudo-types`
	`8`	+* Add PHP 8.0 promoted properties`@param` mutation support to`PhpDocExtractor`
`8`	`9`
`9`	`10`	`6.0`
`10`	`11`	`---`

Lines changed: 15 additions & 13 deletions

Original file line number	Diff line number	Diff line change
`@@ -128,19 +128,11 @@ public function getTypes(string $class, string $property, array $context = []):`
`128`	`128`	`returnnull;`
`129`	`129`	`}`
`130`	`130`
`131`		`-switch ($source) {`
`132`		`-caseself::PROPERTY:`
`133`		`-$tag ='var';`
`134`		`-break;`
`135`		`-`
`136`		`-caseself::ACCESSOR:`
`137`		`-$tag ='return';`
`138`		`-break;`
`139`		`-`
`140`		`-caseself::MUTATOR:`
`141`		`-$tag ='param';`
`142`		`-break;`
`143`		`- }`
	`131`	`+$tag =match ($source) {`
	`132`	`+self::PROPERTY =>'var',`
	`133`	`+self::ACCESSOR =>'return',`
	`134`	`+self::MUTATOR =>'param',`
	`135`	`+ };`
`144`	`136`
`145`	`137`	`$parentClass =null;`
`146`	`138`	`$types = [];`
`@@ -249,9 +241,19 @@ private function getDocBlock(string $class, string $property): array`
`249`	`241`	`return$this->docBlocks[$propertyHash];`
`250`	`242`	`}`
`251`	`243`
	`244`	`+try {`
	`245`	`+$reflectionProperty =new \ReflectionProperty($class,$property);`
	`246`	`+ }catch (\ReflectionException$e) {`
	`247`	`+$reflectionProperty =null;`
	`248`	`+ }`
	`249`	`+`
`252`	`250`	`$ucFirstProperty =ucfirst($property);`
`253`	`251`
`254`	`252`	`switch (true) {`
	`253`	`+case$reflectionProperty?->isPromoted() &&$docBlock =$this->getDocBlockFromConstructor($class,$property):`
	`254`	`+$data = [$docBlock,self::MUTATOR,null];`
	`255`	`+break;`
	`256`	`+`
`255`	`257`	`case$docBlock =$this->getDocBlockFromProperty($class,$property):`
`256`	`258`	`$data = [$docBlock,self::PROPERTY,null];`
`257`	`259`	`break;`

Lines changed: 17 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@`
`16`	`16`	`useSymfony\Component\PropertyInfo\Extractor\PhpDocExtractor;`
`17`	`17`	`useSymfony\Component\PropertyInfo\Tests\Fixtures\Dummy;`
`18`	`18`	`useSymfony\Component\PropertyInfo\Tests\Fixtures\ParentDummy;`
	`19`	`+useSymfony\Component\PropertyInfo\Tests\Fixtures\Php80Dummy;`
`19`	`20`	`useSymfony\Component\PropertyInfo\Tests\Fixtures\TraitUsage\DummyUsedInTrait;`
`20`	`21`	`useSymfony\Component\PropertyInfo\Tests\Fixtures\TraitUsage\DummyUsingTrait;`
`21`	`22`	`useSymfony\Component\PropertyInfo\Type;`
`@@ -429,6 +430,22 @@ public function pseudoTypesProvider(): array`
`429`	`430`	`['positiveInt', [newType(Type::BUILTIN_TYPE_INT,false,null)]],`
`430`	`431`	`];`
`431`	`432`	`}`
	`433`	`+`
	`434`	`+/**`
	`435`	`+ * @dataProvider promotedPropertyProvider`
	`436`	`+ */`
	`437`	`+publicfunctiontestExtractPromotedProperty(string$property, ?array$types)`
	`438`	`+ {`
	`439`	`+$this->assertEquals($types,$this->extractor->getTypes(Php80Dummy::class,$property));`
	`440`	`+ }`
	`441`	`+`
	`442`	`+publicfunctionpromotedPropertyProvider():array`
	`443`	`+ {`
	`444`	`+return [`
	`445`	`+ ['promoted',null],`
	`446`	`+ ['promotedAndMutated', [newType(Type::BUILTIN_TYPE_STRING)]],`
	`447`	`+ ];`
	`448`	`+ }`
`432`	`449`	`}`
`433`	`450`
`434`	`451`	`class EmptyDocBlock`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,13 @@ class Php80Dummy`
`6`	`6`	`{`
`7`	`7`	`publicmixed$mixedProperty;`
`8`	`8`
	`9`	`+/**`
	`10`	`+ * @param string $promotedAndMutated`
	`11`	`+ */`
	`12`	`+publicfunction__construct(privatemixed$promoted,privatemixed$promotedAndMutated)`
	`13`	`+ {`
	`14`	`+ }`
	`15`	`+`
`9`	`16`	`publicfunctiongetFoo():array\|null`
`10`	`17`	`{`
`11`	`18`	`}`

Comments

(0)