Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit85a1c4e

Browse files
committed
change constructor argument type to expect a Key instance
This way we don't hide the fact that the DeduplicateStamp requires the Lockcomponent to be installed.
1 parentcb08480 commit85a1c4e

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

‎src/Symfony/Component/Messenger/Stamp/DeduplicateStamp.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,11 @@
1515

1616
finalclass DeduplicateStampimplements StampInterface
1717
{
18-
privateKey$key;
19-
2018
publicfunction__construct(
21-
string$key,
19+
privateKey$key,
2220
private ?float$ttl =300.0,
2321
privatebool$onlyDeduplicateInQueue =false,
2422
) {
25-
$this->key =newKey($key);
2623
}
2724

2825
publicfunctiononlyDeduplicateInQueue():bool

‎src/Symfony/Component/Messenger/Tests/Middleware/DeduplicateMiddlewareTest.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
namespaceSymfony\Component\Messenger\Tests\Middleware;
1313

14+
useSymfony\Component\Lock\Key;
1415
useSymfony\Component\Lock\LockFactory;
1516
useSymfony\Component\Lock\Store\FlockStore;
1617
useSymfony\Component\Lock\Store\SemaphoreStore;
@@ -39,7 +40,7 @@ public function testDeduplicateMiddlewareIgnoreIfMessageIsNotLockable()
3940
publicfunctiontestDeduplicateMiddlewareIfMessageHasKey()
4041
{
4142
$message =newDummyMessage('Hello');
42-
$envelope =newEnvelope($message, [newDeduplicateStamp('id')]);
43+
$envelope =newEnvelope($message, [newDeduplicateStamp(newKey('id'))]);
4344

4445
if (SemaphoreStore::isSupported()) {
4546
$store =newSemaphoreStore();
@@ -53,7 +54,7 @@ public function testDeduplicateMiddlewareIfMessageHasKey()
5354
$this->assertNotNull($envelope->last(DeduplicateStamp::class));
5455

5556
$message2 =newDummyMessage('Hello');
56-
$envelope2 =newEnvelope($message2, [newDeduplicateStamp('id')]);
57+
$envelope2 =newEnvelope($message2, [newDeduplicateStamp(newKey('id'))]);
5758

5859
$decorator->handle($envelope2,$this->getStackMock(false));
5960

@@ -62,7 +63,7 @@ public function testDeduplicateMiddlewareIfMessageHasKey()
6263
$decorator->handle($envelope,$this->getStackMock(true));
6364

6465
$message3 =newDummyMessage('Hello');
65-
$envelope3 =newEnvelope($message3, [newDeduplicateStamp('id')]);
66+
$envelope3 =newEnvelope($message3, [newDeduplicateStamp(newKey('id'))]);
6667
$decorator->handle($envelope3,$this->getStackMock(true));
6768
}
6869
}

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp